Skip to content

Add acceptance for test for sync.paths equal to two dots #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denik merged 2 commits into from
Jan 21, 2025
Merged

Add acceptance for test for sync.paths equal to two dots #2196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4511417
Add acceptance for test for sync.paths: ".."
denik Jan 20, 2025
8c8885d
try to address /private prefix issue on macos on CI
denik Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions acceptance/acceptance_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,13 @@ func runTest(t *testing.T, dir, coverDir string, repls testdiff.ReplacementsCont
tmpDir = t.TempDir()
}

repls.Set("/private"+tmpDir, "$TMPDIR")
repls.Set("/private"+filepath.Dir(tmpDir), "$TMPPARENT")
repls.Set("/private"+filepath.Dir(filepath.Dir(tmpDir)), "$TMPGPARENT")
repls.Set(tmpDir, "$TMPDIR")
repls.Set(filepath.Dir(tmpDir), "$TMPPARENT")
repls.Set(filepath.Dir(filepath.Dir(tmpDir)), "$TMPGPARENT")

scriptContents := readMergedScriptContents(t, dir)
testutil.WriteFile(t, filepath.Join(tmpDir, EntryPointScript), scriptContents)

Expand Down
5 changes: 5 additions & 0 deletions acceptance/bundle/sync-paths-dotdot/databricks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
bundle:
name: test-bundle
sync:
paths:
- ..
11 changes: 11 additions & 0 deletions acceptance/bundle/sync-paths-dotdot/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
Error: path "$TMPPARENT" is not within repository root "$TMPDIR"

Name: test-bundle
Target: default
Workspace:
User: $USERNAME
Path: /Workspace/Users/$USERNAME/.bundle/test-bundle/default

Found 1 error

Exit code: 1
1 change: 1 addition & 0 deletions acceptance/bundle/sync-paths-dotdot/script
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
$CLI bundle validate
Copy link
Contributor

@andrewnester andrewnester Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't realise it's reproducible by validate as well, struggled to right it for deploy

Loading