Skip to content

Add support for SQL Alerts in DABs#3033

Merged
shreyas-goenka merged 56 commits intomainfrom
add-alerts-v2
Sep 11, 2025
Merged

Add support for SQL Alerts in DABs#3033
shreyas-goenka merged 56 commits intomainfrom
add-alerts-v2

Conversation

@shreyas-goenka
Copy link
Contributor

@shreyas-goenka shreyas-goenka commented Jun 11, 2025

Changes

This PR adds support for SQL alerts to DABs. A follow-up will add support for .dbalert.json files.

Why

#1615

Users can now define an alert in the DAB with syntax like:

bundle:
  name: alerts-basic-$UNIQUE_NAME

resources:
  alerts:
    myalert:
      permissions:
        - level: CAN_RUN
          group_name: users

      custom_summary: "My alert"
      display_name: "My alert $UNIQUE_NAME"
      evaluation:
        comparison_operator: "EQUAL"
        notification:
          notify_on_ok: false
          retrigger_seconds: 1
        source:
          aggregation: "MAX"
          display: "1"
          name: "1"
        threshold:
          value:
            double_value: 2
      query_text: "select 2"
      schedule:
        pause_status: "UNPAUSED"
        quartz_cron_schedule: "44 19 */1 * * ?"
        timezone_id: "Europe/Amsterdam"
      warehouse_id: "dd43ee29fedd958d"

Tests

Manually. And acceptance tests.

@eng-dev-ecosystem-bot
Copy link
Collaborator

eng-dev-ecosystem-bot commented Jul 16, 2025

Run: 17647393955

Env ✅​pass ❌​FAIL 🙈​skip
✅​ aws linux 312 526
✅​ aws windows 313 525
❌​ aws-ucws linux 422 2 424
❌​ aws-ucws windows 423 2 423
✅​ azure linux 312 525
✅​ azure windows 313 524
❌​ azure-ucws linux 422 2 423
❌​ azure-ucws windows 423 2 422
✅​ gcp linux 311 527
✅​ gcp windows 312 526
Test Name aws-ucws linux aws-ucws windows azure-ucws linux azure-ucws windows
TestAccept ❌​FAIL ❌​FAIL ❌​FAIL ❌​FAIL
TestAccept/bundle/deploy/lakebase/synced-database-table ❌​FAIL ❌​FAIL ❌​FAIL ❌​FAIL

@shreyas-goenka shreyas-goenka changed the title [WIP] Add alerts-v2 in DABs Add alerts-v2 in DABs Aug 25, 2025
@shreyas-goenka shreyas-goenka merged commit 87a3046 into main Sep 11, 2025
12 of 13 checks passed
@shreyas-goenka shreyas-goenka deleted the add-alerts-v2 branch September 11, 2025 15:10
@shreyas-goenka shreyas-goenka restored the add-alerts-v2 branch September 16, 2025 08:05
@shreyas-goenka shreyas-goenka deleted the add-alerts-v2 branch September 16, 2025 08:05
shreyas-goenka added a commit that referenced this pull request Sep 16, 2025
## Why
Alerts API today has issues that make the DABs UX borderline unusable.
Examples are:
1. The validation errors are not readable.
2. Server side defaults configured for many fields cause TF errors.

This PR disables alerts until these issues are worked out.

Support for alerts was originally added in
#3033

## Tests
Existing tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants