Force Python scripts in acceptance tests to use UTF-8#3260
Merged
Conversation
pietern
requested review from
andrewnester,
anton-107,
denik and
shreyas-goenka
as code owners
Collaborator
8 failing tests:
|
andrewnester
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
A test failure in #3254 shows the Python scripts called from our acceptance tests were using
cp1252encoding on Windows, which is incompatible with tests using UTF-8. This change makes these tests always use UTF-8.Tests
Adds an emoji to the diff selftest.