Conversation
Collaborator
10 failing tests:
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 1, 2025
## Changes To see which update was run, return updateID in the output. ## Why Necessary for showing summary of run in pipelines. ## Tests Updated bundle and pipelines tests to reflect new output. Sample output: Update ID: 2e522dc5-f817-46dc-b956-2e3e771d9ff3 update ID necessary for follow-up: #3332
76b77bd to
a44303f
Compare
alyssa-db
commented
Aug 5, 2025
| assert.Equal(t, tt.expected, buf.String()) | ||
| }) | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
as a follow-up, we should think about the behavior where certain fields are missing. It's actually a little weird that we just display as normal, when there are certain fields that we expect to exist to not be present, and that we just silently omit them.
Also some edge cases here:
- custom image instead of channel
jefferycheng1
approved these changes
Aug 6, 2025
Collaborator
jefferycheng1
left a comment
There was a problem hiding this comment.
template small nits, make sure to fix before merging.
alyssa-db
added a commit
that referenced
this pull request
Aug 7, 2025
## Changes On run, the corresponding run's update information is displayed. ## Why enrich run information. ## Tests doc can be found [here](https://docs.google.com/document/d/1JUpKLpQM1GP6NV7QtJmtEzU4IDXhl8GxrCNA9n_hvMs/edit?tab=t.0#heading=h.xeb4b9r7dqoi). Sample output: Update ID: dc390a6b-71e0-4274-8382-49472ac85632 Update for pipeline [dev alyssa_gorbaneva] hi_pipeline completed successfully. Pipeline ID: ef8b547f-1e96-43c4-b50a-4c1c3a74e491 Update start time: 2025-08-06T23:00:19Z Update end time: 2025-08-06T23:01:40Z. Pipeline configurations for this update: • All tables are refreshed • Update cause: API_CALL • Serverless compute • Channel: CURRENT • Development mode • Catalog: main • Schema: alyssa_gorbaneva Follows #3331 Follow up: #3337
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
On run, the corresponding run's update information is displayed.
Why
enrich run information.
Tests
doc can be found here.
Sample output:
Update ID: dc390a6b-71e0-4274-8382-49472ac85632
Update for pipeline [dev alyssa_gorbaneva] hi_pipeline completed successfully.
Pipeline ID: ef8b547f-1e96-43c4-b50a-4c1c3a74e491
Update start time: 2025-08-06T23:00:19Z
Update end time: 2025-08-06T23:01:40Z.
Pipeline configurations for this update:
• All tables are refreshed
• Update cause: API_CALL
• Serverless compute
• Channel: CURRENT
• Development mode
• Catalog: main
• Schema: alyssa_gorbaneva
Follows #3331
Follow up: #3337