Skip to content

Comments

pipelines run: enrich output of pipelines#3332

Merged
alyssa-db merged 23 commits intomainfrom
run-events-1
Aug 6, 2025
Merged

pipelines run: enrich output of pipelines#3332
alyssa-db merged 23 commits intomainfrom
run-events-1

Conversation

@alyssa-db
Copy link
Contributor

@alyssa-db alyssa-db commented Jul 31, 2025

Changes

On run, the corresponding run's update information is displayed.

Why

enrich run information.

Tests

doc can be found here.

Sample output:
Update ID: dc390a6b-71e0-4274-8382-49472ac85632
Update for pipeline [dev alyssa_gorbaneva] hi_pipeline completed successfully.
Pipeline ID: ef8b547f-1e96-43c4-b50a-4c1c3a74e491
Update start time: 2025-08-06T23:00:19Z
Update end time: 2025-08-06T23:01:40Z.
Pipeline configurations for this update:
• All tables are refreshed
• Update cause: API_CALL
• Serverless compute
• Channel: CURRENT
• Development mode
• Catalog: main
• Schema: alyssa_gorbaneva

Follows #3331

Follow up: #3337

@eng-dev-ecosystem-bot
Copy link
Collaborator

eng-dev-ecosystem-bot commented Jul 31, 2025

Run: 16790719443

Env ✅‌pass 🔄‌flaky 🙈‌skip
✅‌ aws linux 309 462
✅‌ aws windows 310 461
🔄‌ aws-ucws linux 405 10 362
🔄‌ aws-ucws windows 406 10 361
✅‌ azure linux 309 461
✅‌ azure windows 310 460
🔄‌ azure-ucws linux 408 9 359
🔄‌ azure-ucws windows 410 8 358
✅‌ gcp linux 308 463
✅‌ gcp windows 309 462
10 failing tests:
Test Name aws-ucws linux aws-ucws windows azure-ucws linux azure-ucws windows
TestAccept/bundle/deploy/dashboard/detect-change 🔄‌flaky 🔄‌flaky 🔄‌flaky 🔄‌flaky
TestAccept/bundle/deploy/dashboard/generate_inplace 🔄‌flaky 🔄‌flaky 🔄‌flaky 🔄‌flaky
TestAccept/bundle/deploy/dashboard/nested-folders 🔄‌flaky 🔄‌flaky 🔄‌flaky 🔄‌flaky
TestAccept/bundle/deploy/dashboard/simple 🔄‌flaky 🔄‌flaky 🔄‌flaky 🔄‌flaky
TestAccept/bundle/deploy/dashboard/simple_outside_bundle_root 🔄‌flaky 🔄‌flaky 🔄‌flaky 🔄‌flaky
TestAccept/bundle/deploy/dashboard/simple_syncroot 🔄‌flaky 🔄‌flaky 🔄‌flaky 🔄‌flaky
TestAccept/bundle/deployment/bind/dashboard 🔄‌flaky 🔄‌flaky 🔄‌flaky ✅‌pass
TestAccept/bundle/deployment/bind/dashboard/recreation 🔄‌flaky 🔄‌flaky 🔄‌flaky 🔄‌flaky
TestDashboardAssumptions_WorkspaceImport 🔄‌flaky 🔄‌flaky 🔄‌flaky 🔄‌flaky
TestFetchRepositoryInfoAPI_FromRepo 🔄‌flaky 🔄‌flaky ✅‌pass ✅‌pass

@alyssa-db alyssa-db temporarily deployed to test-trigger-is August 1, 2025 03:41 — with GitHub Actions Inactive
@alyssa-db alyssa-db temporarily deployed to test-trigger-is August 1, 2025 04:13 — with GitHub Actions Inactive
@alyssa-db alyssa-db temporarily deployed to test-trigger-is August 1, 2025 05:42 — with GitHub Actions Inactive
@alyssa-db alyssa-db marked this pull request as ready for review August 1, 2025 05:45
@alyssa-db alyssa-db temporarily deployed to test-trigger-is August 1, 2025 05:50 — with GitHub Actions Inactive
github-merge-queue bot pushed a commit that referenced this pull request Aug 1, 2025
## Changes
To see which update was run, return updateID in the output.

## Why
Necessary for showing summary of run in pipelines. 

## Tests
Updated bundle and pipelines tests to reflect new output.

Sample output:
Update ID: 2e522dc5-f817-46dc-b956-2e3e771d9ff3

update ID necessary for follow-up:
#3332
Base automatically changed from run-events-0 to main August 1, 2025 06:44
@alyssa-db alyssa-db temporarily deployed to test-trigger-is August 1, 2025 18:52 — with GitHub Actions Inactive
@alyssa-db alyssa-db force-pushed the run-events-1 branch 2 times, most recently from 76b77bd to a44303f Compare August 1, 2025 22:21
@alyssa-db alyssa-db requested a review from jefferycheng1 August 2, 2025 00:14
@alyssa-db alyssa-db temporarily deployed to test-trigger-is August 2, 2025 00:20 — with GitHub Actions Inactive
@alyssa-db alyssa-db temporarily deployed to test-trigger-is August 6, 2025 15:31 — with GitHub Actions Inactive
@alyssa-db alyssa-db temporarily deployed to test-trigger-is August 6, 2025 19:11 — with GitHub Actions Inactive
@alyssa-db alyssa-db temporarily deployed to test-trigger-is August 6, 2025 19:28 — with GitHub Actions Inactive
assert.Equal(t, tt.expected, buf.String())
})
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a follow-up, we should think about the behavior where certain fields are missing. It's actually a little weird that we just display as normal, when there are certain fields that we expect to exist to not be present, and that we just silently omit them.

Also some edge cases here:

  • custom image instead of channel

Copy link
Collaborator

@jefferycheng1 jefferycheng1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

template small nits, make sure to fix before merging.

@alyssa-db alyssa-db temporarily deployed to test-trigger-is August 6, 2025 23:05 — with GitHub Actions Inactive
@alyssa-db alyssa-db enabled auto-merge August 6, 2025 23:05
@alyssa-db alyssa-db added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit 513d3de Aug 6, 2025
13 checks passed
@alyssa-db alyssa-db deleted the run-events-1 branch August 6, 2025 23:42
@alyssa-db alyssa-db restored the run-events-1 branch August 6, 2025 23:49
alyssa-db added a commit that referenced this pull request Aug 7, 2025
## Changes
On run, the corresponding run's update information is displayed.

## Why
enrich run information.

## Tests
doc can be found
[here](https://docs.google.com/document/d/1JUpKLpQM1GP6NV7QtJmtEzU4IDXhl8GxrCNA9n_hvMs/edit?tab=t.0#heading=h.xeb4b9r7dqoi).

Sample output:
Update ID: dc390a6b-71e0-4274-8382-49472ac85632
Update for pipeline [dev alyssa_gorbaneva] hi_pipeline completed
successfully.
Pipeline ID: ef8b547f-1e96-43c4-b50a-4c1c3a74e491
Update start time: 2025-08-06T23:00:19Z
Update end time: 2025-08-06T23:01:40Z.
Pipeline configurations for this update:
• All tables are refreshed
• Update cause: API_CALL
• Serverless compute
• Channel: CURRENT
• Development mode
• Catalog: main
• Schema: alyssa_gorbaneva

Follows #3331

Follow up: #3337
github-merge-queue bot pushed a commit that referenced this pull request Aug 15, 2025
## Changes
Acceptance tests, following #3337
and #3332

Test output of `pipelines run` based on test.toml API endpoints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants