Merged
Conversation
shreyas-goenka
approved these changes
Aug 5, 2025
andrewnester
approved these changes
Aug 5, 2025
Contributor
Author
|
For context, for receiver rule I asked cursor to pick the one with most existing cases. The linter reports this: |
Collaborator
11 failing tests:
|
pietern
approved these changes
Aug 5, 2025
alyssa-db
pushed a commit
that referenced
this pull request
Aug 7, 2025
## Changes Enable all rules except one (ST1003) which produces too many changes so deserves its own PR. Some had autofix, some were fixed with cursor. ## Why No reason to keep them disabled. I think they were disabled originally to minimize changes to original PR. ## Tests Existing tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Enable all rules except one (ST1003) which produces too many changes so deserves its own PR. Some had autofix, some were fixed with cursor.
Why
No reason to keep them disabled. I think they were disabled originally to minimize changes to original PR.
Tests
Existing tests.