Merged
Conversation
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
Collaborator
6 failing tests:
|
pietern
approved these changes
Aug 28, 2025
| } | ||
| value, err := structaccess.Get(config, fieldPath) | ||
| dynPath, err := dyn.NewPathFromString(fieldPath) | ||
| if err != nil { |
Contributor
There was a problem hiding this comment.
Because the above code uses dynvar, I don't think this ever triggers.
We should be more strict here to begin with and make sure everything after ${ is valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Make structaccess.Get accept dyn.Path rather than string.
Follow up to #3466
Why
I plan to check more than one struct (config and remote state) and it's good to reuse parsed path between those.
Tests
Existing tests.
There is also a new test added but it's not a regression test for this PR (the bad syntax never reaches NewPathFromString), just on related topic.