Disable rate limit in tnresources unit tests#3579
Merged
Conversation
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
shreyas-goenka
approved these changes
Sep 9, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 10, 2025
) ## Changes Respect DATABRICKS_RATE_LIMIT variable and pass it to tests if set. If not set, set to higher defaults depending on local/cloud. Related: #3579 ## Tests New acc test with parallel resources that is good to demo the difference. Manually try different rate limits: Set a very low limit: ``` ~/work/cli-main/acceptance/bundle/resources/independent % DATABRICKS_RATE_LIMIT=1 testme -v -count=1 + go test ../../.. -run ^TestAccept$/^bundle$/^resources$/^independent$ -v -count=1 … --- PASS: TestAccept/bundle/resources/independent/DATABRICKS_CLI_DEPLOYMENT=direct-exp (16.47s) --- PASS: TestAccept/bundle/resources/independent/DATABRICKS_CLI_DEPLOYMENT=terraform (22.34s) ``` Restore SDK default: ``` ~/work/cli-main/acceptance/bundle/resources/independent % DATABRICKS_RATE_LIMIT=15 testme -v -count=1 + go test ../../.. -run ^TestAccept$/^bundle$/^resources$/^independent$ -v -count=1 --- PASS: TestAccept/bundle/resources/independent/DATABRICKS_CLI_DEPLOYMENT=direct-exp (1.52s) --- PASS: TestAccept/bundle/resources/independent/DATABRICKS_CLI_DEPLOYMENT=terraform (5.02s) ``` New default: ``` ~/work/cli-main/acceptance/bundle/resources/independent % testme -v -count=1 + go test ../../.. -run ^TestAccept$/^bundle$/^resources$/^independent$ -v -count=1 --- PASS: TestAccept/bundle/resources/independent/DATABRICKS_CLI_DEPLOYMENT=direct-exp (0.46s) --- PASS: TestAccept/bundle/resources/independent/DATABRICKS_CLI_DEPLOYMENT=terraform (2.36s) ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This is running against local testserver.
Before:
After: