Skip to content

direct: add FieldTriggers(); remove ClassifyChanges(), RecreateFields()#3595

Merged
denik merged 2 commits intomainfrom
denik/remove-classify-changes
Sep 11, 2025
Merged

direct: add FieldTriggers(); remove ClassifyChanges(), RecreateFields()#3595
denik merged 2 commits intomainfrom
denik/remove-classify-changes

Conversation

@denik
Copy link
Contributor

@denik denik commented Sep 11, 2025

Changes

New method FieldTriggers(), which is a more powerful version of RecreateFields() that allows associate any action with a field.

Builds on top of #3585

Why

This covers existing classification use cases without custom code.

We might still need ClassifyChange function in the future, but exact types involved will likely change by that time (with regard to serialized plan work).

Tests

Existing tests.

@eng-dev-ecosystem-bot
Copy link
Collaborator

eng-dev-ecosystem-bot commented Sep 11, 2025

Run: 17651253066

Env ✅​pass ❌​FAIL 🔄​flaky 🙈​skip
🔄​ aws linux 309 3 526
✅​ aws windows 313 525
❌​ aws-ucws linux 422 2 424
❌​ aws-ucws windows 423 2 423
✅​ azure linux 312 525
✅​ azure windows 313 524
❌​ azure-ucws linux 422 2 423
❌​ azure-ucws windows 423 2 422
✅​ gcp linux 311 527
✅​ gcp windows 312 526
Test Name aws linux aws-ucws linux aws-ucws windows azure-ucws linux azure-ucws windows
TestAccept 🔄​flaky ❌​FAIL ❌​FAIL ❌​FAIL ❌​FAIL
TestAccept/bundle/deploy/lakebase/synced-database-table 🙈​skip ❌​FAIL ❌​FAIL ❌​FAIL ❌​FAIL
TestAccept/bundle/templates/default-python/integration_classic 🔄​flaky ✅​pass ✅​pass ✅​pass ✅​pass
TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_CLI_DEPLOYMENT=terraform/UV_PYTHON=3.9 🔄​flaky ✅​pass ✅​pass ✅​pass ✅​pass

@denik denik temporarily deployed to test-trigger-is September 11, 2025 15:18 — with GitHub Actions Inactive
@denik denik force-pushed the denik/remove-classify-changes branch from 7556837 to c4afdb7 Compare September 11, 2025 16:39
@denik denik temporarily deployed to test-trigger-is September 11, 2025 16:39 — with GitHub Actions Inactive
@denik denik enabled auto-merge September 11, 2025 16:39
@denik denik disabled auto-merge September 11, 2025 17:13
@denik denik merged commit cc76ef2 into main Sep 11, 2025
12 of 13 checks passed
@denik denik deleted the denik/remove-classify-changes branch September 11, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants