Skip to content

Comments

Deflake acceptance tests#3672

Merged
lennartkats-db merged 4 commits intomainfrom
deflake-acceptance-tests
Sep 29, 2025
Merged

Deflake acceptance tests#3672
lennartkats-db merged 4 commits intomainfrom
deflake-acceptance-tests

Conversation

@lennartkats-db
Copy link
Contributor

@lennartkats-db lennartkats-db commented Sep 29, 2025

Changes

This PR makes some tactical changes to the acceptance test configuration to deflake them. They've been quite flaky for me, especially in agent settings. I asked an agent to stress test them and address problems:

  • The default timeout for tests is now 30s instead of 20s (common cause of failures)
  • run-local-node tests now automatically use a free port (very common cause of failures)
  • The timeout self-test is less timing sensitive (rare cause of failures)

Tests

  • Stress tested by AI

@eng-dev-ecosystem-bot
Copy link
Collaborator

eng-dev-ecosystem-bot commented Sep 29, 2025

Run: 18095531078

Env ✅​pass 🙈​skip
✅​ aws linux 312 531
✅​ aws windows 313 530
✅​ aws-ucws linux 425 428
✅​ aws-ucws windows 426 427
✅​ azure linux 312 530
✅​ azure windows 313 529
✅​ azure-ucws linux 425 427
✅​ azure-ucws windows 426 426
✅​ gcp linux 311 532
✅​ gcp windows 312 531

@lennartkats-db lennartkats-db added this pull request to the merge queue Sep 29, 2025
Merged via the queue into main with commit 739b1f7 Sep 29, 2025
13 checks passed
@lennartkats-db lennartkats-db deleted the deflake-acceptance-tests branch September 29, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants