Initial implementation of the local cache layer #3678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able caching in populate_current_user_cached
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
approved these changes
Dec 8, 2025
| "bundle_mode": "TYPE_UNSPECIFIED", | ||
| "workspace_artifact_path_type": "WORKSPACE_FILE_SYSTEM" | ||
| "workspace_artifact_path_type": "WORKSPACE_FILE_SYSTEM", | ||
| "local_cache_measurements_ms": [...redacted...] |
Contributor
There was a problem hiding this comment.
(optional) maybe worth recording the keys for the int map.
| // TestFingerprintStability tests that the fingerprintToHash function returns the same hash for the same input. | ||
| func TestFingerprintStability(t *testing.T) { | ||
| fingerprint1 := struct { | ||
| Key string `json:"key"` |
Contributor
There was a problem hiding this comment.
What happens if there's an embedded struct with an override for the same field:
struct foo {
A string
B string
}
struct bar {
foo
A string
}
Do bar{A:"abc"} and bar{foo{A:"abc"}} compute to the same has or different?
This is a scenario that arises in dashboards so atleast we should document what happens in a unit test.
Contributor
There was a problem hiding this comment.
This has to be a separate hash, but why dashboards matter here?
Contributor
There was a problem hiding this comment.
but why dashboards matter here?
Maybe someday we might want to cache dashboards... Not a real usecase but atleast worth pointing out that the hashing is not bulletproof.
|
|
||
| // getAuthorizationHeader extracts the Authorization header from the workspace client configuration. | ||
| // If it fails to authenticate, it returns an empty string. | ||
| func (b *Bundle) getAuthorizationHeader() string { |
Contributor
There was a problem hiding this comment.
When doing the cache miss analysis, it'll be interesting to corellate that with auth type. I would expect oauth-u2m to have more misses due to short lived API tokens.
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Dec 9, 2025
| === First call in a session is expected to be a cache miss: | ||
| [DEBUG_TIMESTAMP] Debug: [Local Cache] using cache key: [SHA256_HASH] | ||
| [DEBUG_TIMESTAMP] Debug: [Local Cache] failed to stat cache file: (redacted) | ||
| [DEBUG_TIMESTAMP] Debug: [Local Cache] cache miss, computing |
Contributor
There was a problem hiding this comment.
nit: should include function name that is being computed? This maybe more relevant in the future where is more than one function.
| account Databricks Account Commands | ||
| api Perform Databricks API call | ||
| auth Authentication related commands | ||
| cache Local cache related commands |
Contributor
There was a problem hiding this comment.
From the description it's not obvious that is user-level cache (and not whatever we have in .databricks). Perhaps make it explicit "user-level cache"? cc @juliacrawf-db
denik
reviewed
Dec 9, 2025
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
changed the title
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
approved these changes
Dec 10, 2025
| Use: "cache", | ||
| Short: "Local cache related commands", | ||
| Long: "Manage local cache used by the Databricks CLI for improved performance", | ||
| } |
Contributor
There was a problem hiding this comment.
Please update the short/long for this.
pietern
reviewed
Dec 10, 2025
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
@andrewnester Please take a look at the PR summary as well.
The implementation has drifted from the original summary.
pietern
reviewed
Dec 10, 2025
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
approved these changes
Dec 10, 2025
Collaborator
|
Commit: 100a4a6
22 interesting tests: 14 flaky, 7 RECOVERED, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR introduces a local file-based cache layer for the Databricks CLI to improve performance of repeated operations.
New libs/cache package:
Cache Modes:
New CLI command:
Bundle Integration:
Why
This is the first attempt to speed up subsequent
databricks bundlecommands that a bundle developer runs while developing a bundleTests
libs/cache