direct: Added support for clusters deployment#3682
Merged
andrewnester merged 14 commits intomainfrom Oct 8, 2025
Merged
Conversation
andrewnester
added a commit
that referenced
this pull request
Oct 1, 2025
## Changes Added support for ClassifyChanges ## Why Needed for #3682 Some resources might have different types of changes based on their remote state. For example, the cluster's resize action becomes an update if the cluster is stopped. In order to do such classification, we need access to the remote state, so we are introducing a new ClassifyChange method. ClassifyChange is called first, if it returns ActionTypeUnset, ClassifyByTriggers called ## Tests <!-- How have you tested the changes? --> <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
9 failing tests:
|
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
requested review from
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
commented
Oct 2, 2025
| } | ||
|
|
||
| localAction, localChangeMap := convertChangesToTriggersMap(adapter, localDiff) | ||
| remoteState, err := adapter.DoRefresh(ctx, dbentry.ID) |
Contributor
Author
There was a problem hiding this comment.
Moving state refresh to before local actions because we need to have access to the remote state to classify local diffs as well, aka resize vs. update if the cluster is running or not
Contributor
|
Can we enable these tests? |
denik
reviewed
Oct 3, 2025
| return err | ||
| } | ||
| return nil | ||
| } |
Contributor
There was a problem hiding this comment.
we don't need WaitAfterCreate/Update?
Contributor
Author
There was a problem hiding this comment.
@denik no, we don't wait wait for clusters to start / update now in TF as well
denik
reviewed
Oct 3, 2025
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Oct 7, 2025
acceptance/bundle/resources/clusters/deploy/update-and-resize-autoscale/databricks.yml.tmpl
Outdated
Show resolved
Hide resolved
acceptance/bundle/resources/clusters/deploy/update-and-resize-autoscale/script
Show resolved
Hide resolved
acceptance/bundle/resources/clusters/deploy/update-and-resize-autoscale/script
Show resolved
Hide resolved
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added support for cluster deployment for direct deployment
As part of the implementation for direct, added the default values 60 for autotermination_minutes, the same value as in TF.
Why
Behaviour matches the one in Terraform
Tests
Enabled existing cluster acceptance tests for direct as well + added a new one which does da different type of updates