Enable gocritic offBy1 and fix import warning slicing (codex)#3713
Merged
denik merged 2 commits intodatabricks:mainfrom Oct 3, 2025
Merged
Conversation
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
pietern
approved these changes
Oct 3, 2025
| // Remove output starting from Warning until end of output, if present. | ||
| if idx := strings.Index(output, "Warning:"); idx != -1 { | ||
| output = output[:idx] | ||
| } |
Contributor
There was a problem hiding this comment.
Unrelated to the change at hand, but this should really use https://pkg.go.dev/strings#CutPrefix
Contributor
Author
There was a problem hiding this comment.
CutPrefix would remove prefix, but this removes suffix :)
lennartkats-db
approved these changes
Oct 3, 2025
Collaborator
9 failing tests:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
https://chatgpt.com/s/cd_68df8308cdf081918babe8e111fb5dce