Add source_linked_deployment & git_folder_path to metadata.json#3719
Merged
Add source_linked_deployment & git_folder_path to metadata.json#3719
Conversation
rclarey
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
rclarey
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
rclarey
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
rclarey
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
reviewed
Oct 6, 2025
rclarey
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
| } | ||
|
|
||
| // Set the git folder path for deployments from the workspace | ||
| if b.WorktreeRoot != nil && strings.HasPrefix(b.WorktreeRoot.Native(), "/Workspace/") { |
Contributor
There was a problem hiding this comment.
FYI we already have some of this information captured in the metadata today:
Do we need the absolute git folder path separately? Just curious about the usecase.
Contributor
Author
There was a problem hiding this comment.
Yes we need to capture the absolute git folder path so we can reconstruct the full path to a resource definition YAML file. e.g. to get the path to a pipeline definition file we combine
GitFolderPath + BundleRootPath + Pipelines[pipelineName].RelativePath
This will be used for breakglass UI where we want to link to where a deployed resource is defined in its DAB
rclarey
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
rclarey
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
rclarey
changed the title
shreyas-goenka
approved these changes
Oct 7, 2025
andrewnester
approved these changes
Oct 7, 2025
rclarey
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
rclarey
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
rclarey
force-pushed
the
more-deployment-metadata
branch
from
464d2f2 to
cd87e8a
Compare
rclarey
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add two new fields to
metadata.json:config.presets.source_linked_deploymentextra.git_folder_pathWhy
To support Lakeflow integration with DABs
Tests
Added unit tests