Add a summary of how many files are uploaded and ignored as part of bundle deploy#3739
Closed
andrewnester wants to merge 13 commits intomainfrom
Closed
Add a summary of how many files are uploaded and ignored as part of bundle deploy#3739andrewnester wants to merge 13 commits intomainfrom
andrewnester wants to merge 13 commits intomainfrom
Conversation
andrewnester
requested review from
anton-107,
denik,
jefferycheng1,
kanterov,
lennartkats-db,
pietern and
shreyas-goenka
as code owners
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
12 failing tests:
|
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
force-pushed
the
feat/show-msg-gitignore
branch
from
2477bc1 to
5c95e65
Compare
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
commented
Oct 13, 2025
| "method": "POST", | ||
| "path": "/api/2.0/workspace/mkdirs", | ||
| "body": { | ||
| "path": "/Workspace/Users/[USERNAME]/.bundle/my_default_python/prod/files/scratch" |
Contributor
Author
There was a problem hiding this comment.
This folder was always in template and it seems like previous gitignore logic was too eager
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Oct 15, 2025
Contributor
denik
left a comment
denik
left a comment
There was a problem hiding this comment.
General question - does this result in the same number of syscalls as before (just extra bookkeeping) or does it do more work on file system?
|
|
||
| >>> [CLI] bundle deploy | ||
| Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files... | ||
| Uploaded [NUMID] files (ignored [NUMID] directories by .gitignore) |
Contributor
There was a problem hiding this comment.
Why have 2 messages for the same event? If uploading files then I won't see number, right?
Contributor
Author
There was a problem hiding this comment.
For the ux
- The first one shows that we started to do the uploading
- 2nd one - how many uploaded
We could add a number to the first message, but it would require changing sync.RunOnce interface to take the list of files. Don't really have a strong opinion if it's best to keep one longer message or 2 separate ones
|
|
||
| [[Repls]] | ||
| Old = 'Uploaded \d+ files \(ignored \d+ directories( and \d+ files)? by .gitignore\)' | ||
| New = 'Uploaded [NUMID] files (ignored [NUMID] directories by .gitignore)' |
Contributor
There was a problem hiding this comment.
Why Local and Cloud have different number of files?
Contributor
Author
There was a problem hiding this comment.
I don't yet have answer for this, need to dive deeper into this
Contributor
There was a problem hiding this comment.
This is a review completely generated by claude and not reviewed by me. I was testing the reviewbot, but this might be useful.
Issues Found
- Confusing comment logic - Line 277 in libs/sync/sync.go has a confusing double-negative comment about the exclude filtering logic
- Missing unit tests - No unit tests for the message formatting logic in bundle/deploy/files/upload.go, especially edge cases like zero counts or combinations of exclusion types
- Performance consideration - The exclude filtering iterates over all files after building the set (lines 270-282 in sync.go), which could be slow for large filesets. Consider documenting this trade-off
Suggestions
- Add unit tests for the message formatting logic to ensure edge cases are handled correctly (e.g., only directories excluded, only files excluded, both, neither)
- Consider adding a helper method to FileList for generating the message, making it more testable
- The ExcludedBySyncExclude field could have a more descriptive name like ExcludedBySyncExcludePatterns
Review generated by reviewbot
| log.Errorf(ctx, "cannot check if file matches exclude pattern: %s", err) | ||
| return nil, err | ||
| } | ||
| // If not ignored by excluder, it means the file matches exclude patterns |
Contributor
There was a problem hiding this comment.
This comment is confusing due to double-negative logic. The excludeIgnorer uses an includer with inverted semantics where IgnoreFile() returns false when a file matches the pattern. Consider clarifying: "If file matches exclude pattern (indicated by IgnoreFile returning false), remove it"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add a summary of how many files are uploaded and ignored as part of
bundle deploySome of the tests (which run on Local and Cloud) have a different number of files uploaded/ignored, thus sometimes we include a replacement for the number of files in the message we print in acceptance tests.
Tests
Existing acceptance tests show the output