Skip to content

Comments

Add revive linter#3755

Merged
denik merged 3 commits intodatabricks:mainfrom
denik:codex/add-revive-linter-and-fix-issues
Oct 15, 2025
Merged

Add revive linter#3755
denik merged 3 commits intodatabricks:mainfrom
denik:codex/add-revive-linter-and-fix-issues

Conversation

@denik
Copy link
Contributor

@denik denik commented Oct 13, 2025

Changes

  • Add revive linter with a subset of rules.
  • Fix issues found.

Why

Good rules, some stylistic, some catch real bugs, e.g. recursion in IsZero().


https://chatgpt.com/codex/tasks/task_e_68eccd655f1c8325aded897ab7a3bddb

Original PR: denik#6

@github-actions
Copy link

An authorized user can trigger integration tests manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 3755
  • Commit SHA: dc35837bb651cb3125d7d33ace2da3871b5fb5c2

Checks will be approved automatically on success.

@denik denik enabled auto-merge October 15, 2025 12:30
@eng-dev-ecosystem-bot
Copy link
Collaborator

eng-dev-ecosystem-bot commented Oct 15, 2025

Run: 18528598874

Env 🔄​flaky ✅​pass 🙈​skip
✅​ aws linux 322 545
✅​ aws windows 323 544
✅​ aws-ucws linux 438 441
✅​ aws-ucws windows 439 440
✅​ azure linux 322 544
🔄​ azure windows 5 318 543
✅​ azure-ucws linux 438 440
✅​ azure-ucws windows 439 439
🔄​ gcp linux 3 318 546
🔄​ gcp windows 3 319 545
9 failing tests:
Test Name azure windows gcp linux gcp windows
TestAccept 🔄​f 🔄​f 🔄​f
TestAccept/bundle/resources/experiments/basic ✅​p ✅​p 🔄​f
TestAccept/bundle/resources/experiments/basic/DATABRICKS_BUNDLE_ENGINE=terraform ✅​p ✅​p 🔄​f
TestAccept/bundle/resources/jobs/double-underscore-keys ✅​p 🔄​f ✅​p
TestAccept/bundle/resources/jobs/double-underscore-keys/DATABRICKS_BUNDLE_ENGINE=terraform ✅​p 🔄​f ✅​p
TestAccept/bundle/templates/default-python/integration_classic 🔄​f ✅​p ✅​p
TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_BUNDLE_ENGINE=direct-exp/UV_PYTHON=3.12 🔄​f ✅​p ✅​p
TestFilerWorkspaceNotebook 🔄​f ✅​p ✅​p
TestFilerWorkspaceNotebook/pythonJupyterNb.ipynb 🔄​f ✅​p ✅​p

@denik denik added this pull request to the merge queue Oct 15, 2025
Merged via the queue into databricks:main with commit 106c059 Oct 15, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants