Gracefully exit when terminated mid deploy / destroy#3758
Closed
shreyas-goenka wants to merge 7 commits intomainfrom
Closed
Gracefully exit when terminated mid deploy / destroy#3758shreyas-goenka wants to merge 7 commits intomainfrom
shreyas-goenka wants to merge 7 commits intomainfrom
Conversation
pietern
reviewed
Oct 14, 2025
Collaborator
49 failing tests:
|
denik
reviewed
Oct 14, 2025
2db9670 to
3023134
Compare
shreyas-goenka
commented
Nov 6, 2025
| ) | ||
|
|
||
| type Goal string | ||
| type release struct{} |
Contributor
Author
There was a problem hiding this comment.
We don't need goal anymore since lock.Release is idempotent.
|
This PR has not received an update in a while. If you want to keep this PR open, please leave a comment below or push a new commit and auto-close will be canceled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds graceful signal handling (SIGINT, SIGTERM, SIGHUP, SIGQUIT) during bundle deployment and destruction. When interrupted, the CLI waits for the current operation to complete, releases the deployment lock, and exits with the appropriate exit code.
Makes lock release idempotent to handle race conditions when multiple cleanup paths attempt to release the lock.
Tests