Add cloud-only acceptance tests for ssh tunnel #3825
+92
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilia-db
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
ilia-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilia-db
force-pushed
the
ssh-tunnel-integ-tests
branch
from
d307bfa to
a988e53
Compare
ilia-db
force-pushed
the
ssh-tunnel-integ-tests-followup
branch
from
24d5662 to
eb3c747
Compare
ilia-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
12 failing tests:
|
denik
reviewed
Oct 27, 2025
acceptance/acceptance_test.go
Outdated
| } | ||
|
|
||
| func CreateReleaseArtifact(t *testing.T, cwd, releasesDir, osName, arch string) { | ||
| tempBuildDir := filepath.Join(releasesDir, "tmp_"+arch) |
Contributor
There was a problem hiding this comment.
why is this directory called tmp_ ? Is it cleaned up?
This is similar to BuildCLI() and there we build into the same directory, it's faster on second run when file is already present and nothing changed.
Can we re-use BuildCLI() function here? This will reuse build cache. When run on linux it will also re-use build artifact (even if you call go build for second time, it'll be faster).
Contributor
Author
There was a problem hiding this comment.
It make sense to re-use BuildCLI, added that in the new revision
| zipName := fmt.Sprintf("databricks_cli_%s_%s.zip", osName, arch) | ||
| zipPath := filepath.Join(releasesDir, zipName) | ||
|
|
||
| zipFile, err := os.Create(zipPath) |
Contributor
There was a problem hiding this comment.
Should we skip zipping if its mtime > mtime of the binary?
Contributor
Author
There was a problem hiding this comment.
Based on my testing go build modifies the binaries all the time, even if it skips the actual compilation phase. I'm re-creating the archives all the time because of it, but because the builds themselves are now cached, it's still pretty fast on subsequent runs
But this time also store private client key in the secrets scope.
ilia-db
force-pushed
the
ssh-tunnel-integ-tests-followup
branch
from
eb3c747 to
f813e3f
Compare
ilia-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilia-db
force-pushed
the
ssh-tunnel-integ-tests-followup
branch
from
ad6d8e6 to
20e1607
Compare
ilia-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilia-db
force-pushed
the
ssh-tunnel-integ-tests-followup
branch
from
20e1607 to
e7136fc
Compare
ilia-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Based on #3775
Make a simple connection with "echo 'Hello'" and check that databricks ssh connect output has it.
SSH tunnel requires linux releases to be present, so it can upload them to the workspace for the ssh server to use. Added the build step directly to the acceptance_test, similar to how we build the CLI itself there. Initially I've modified our runner to install goreleaser and running make snapshot-release, but it takes over 10m on linux machines. Current build step only adds ~1m to the test time.