direct: Handle data_security_mode aliases for clusters

[andrewnester]

Changes

Handle data_security_mode aliases for clusters

Why

To be in line with TF provider behaviour, we skip diff if it's just a change of the alias
https://github.com/databricks/terraform-provider-databricks/blob/main/clusters/resource_cluster.go#L109-L117

Tests

Added an acceptance test

[denik]

I suppose it's better to skip it than to remap these in RemapState. Separate question (follow up PR) - should we also return a reason in ClassifyChanges? So we can show reason="alias" next to action="skip" in the plan.

[andrewnester]

Tbh I don't have a preference on adding the reason

[pietern]

Separate reason in the plan would be nice. Can be separate PR.

[eng-dev-ecosystem-bot]

Run: 19074782508

	Env	❌​FAIL	🟨​KNOWN	🔄​flaky	💚​RECOVERED	🙈​SKIP	✅​pass	🙈​skip
🔄​	aws linux			1	1	1	325	591
🔄​	aws windows			5	1	1	322	590
🔄​	aws-ucws linux			2	1	1	447	486
💚​	aws-ucws windows				1	1	450	485
🔄​	azure linux			3		1	324	590
💚​	azure windows				1	1	327	589
💚​	azure-ucws linux				1	1	445	485
💚​	azure-ucws windows				1	1	446	484
❌​	gcp linux	17	1			1	308	592
❌​	gcp windows	34	1			1	292	591

51 failing tests:

Test Name	aws linux	aws windows	aws-ucws linux	aws-ucws windows	azure linux	azure windows	azure-ucws linux	azure-ucws windows	gcp linux	gcp windows
TestAccept	💚​R	💚​R	💚​R	💚​R	🔄​f	💚​R	💚​R	💚​R	🟨​K	🟨​K
TestAccept/bundle/deploy/empty-bundle	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F	❌​F
TestAccept/bundle/deploy/empty-bundle/DATABRICKS_BUNDLE_ENGINE=direct	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F	✅​p
TestAccept/bundle/deploy/empty-bundle/DATABRICKS_BUNDLE_ENGINE=terraform	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestAccept/bundle/deployment/bind/cluster	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F	✅​p
TestAccept/bundle/deployment/bind/dashboard	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F	✅​p
TestAccept/bundle/deployment/bind/dashboard/recreation	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F	✅​p
TestAccept/bundle/deployment/bind/job/generate-and-bind	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F	✅​p
TestAccept/bundle/deployment/bind/model-serving-endpoint	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestAccept/bundle/deployment/unbind/permissions	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestAccept/bundle/generate/auto-bind	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestAccept/bundle/local_state_staleness	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F	❌​F
TestAccept/bundle/local_state_staleness/DATABRICKS_BUNDLE_ENGINE=direct	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F	✅​p
TestAccept/bundle/local_state_staleness/DATABRICKS_BUNDLE_ENGINE=terraform	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F	❌​F
TestAccept/bundle/resources/clusters/deploy/data_security_mode	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestAccept/bundle/resources/clusters/deploy/data_security_mode/DATABRICKS_BUNDLE_ENGINE=direct	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestAccept/bundle/resources/clusters/deploy/data_security_mode/DATABRICKS_BUNDLE_ENGINE=terraform	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestAccept/bundle/resources/clusters/deploy/simple	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestAccept/bundle/resources/clusters/deploy/simple/DATABRICKS_BUNDLE_ENGINE=terraform	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestAccept/bundle/resources/dashboards/detect-change	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestAccept/bundle/resources/dashboards/generate_inplace	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestAccept/bundle/resources/dashboards/nested-folders	✅​p	✅​p	🔄​f	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestAccept/bundle/resources/dashboards/simple	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestAccept/bundle/resources/secret_scopes	✅​p	✅​p	🔄​f	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F	✅​p
TestAccept/bundle/run/app-with-job	🙈​S	🙈​S	🙈​S	🙈​S	🙈​S	🙈​S	🙈​S	🙈​S	🙈​S	🙈​S
TestAccept/bundle/templates/default-python/combinations/classic	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F	❌​F
TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=direct/DLT=yes/NBOOK=no/PY=no	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F	❌​F
TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=terraform/DLT=yes/NBOOK=no/PY=no	✅​p	🔄​f	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p
TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=terraform/DLT=yes/NBOOK=no/PY=yes	✅​p	🔄​f	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p
TestAccept/bundle/templates/default-python/integration_classic	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F	❌​F
TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_BUNDLE_ENGINE=direct/UV_PYTHON=3.11	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F	❌​F
TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_BUNDLE_ENGINE=direct/UV_PYTHON=3.12	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F	❌​F
TestAccept/selftest/record_cloud/pipeline-crud	✅​p	✅​p	✅​p	✅​p	🔄​f	✅​p	✅​p	✅​p	✅​p	✅​p
TestAccept/selftest/record_cloud/pipeline-crud/DATABRICKS_BUNDLE_ENGINE=terraform	✅​p	✅​p	✅​p	✅​p	🔄​f	✅​p	✅​p	✅​p	✅​p	✅​p
TestBundleInitHelpers	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestGenerateFromExistingJobAndDeploy	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestGenerateFromExistingPipelineAndDeploy	🔄​f	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestFsCpDir	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestFsCpDir/dbfs_to_dbfs	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestFsLsOnEmptyDir	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestFsLsOnEmptyDir/dbfs	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestFsLsOnFile	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestFsLsOnFile/dbfs	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestFsMkdir	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestFsMkdir/dbfs	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestFilerReadDir	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F	❌​F
TestFilerReadDir/dbfs	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F	✅​p
TestFilerReadDir/workspace_files	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	❌​F
TestTagKeyAWS	✅​p	🔄​f	✅​p	✅​p	🙈​s	🙈​s	🙈​s	🙈​s	🙈​s	🙈​s
TestTagKeyAWS/valid	✅​p	🔄​f	✅​p	✅​p
TestTelemetryEndpoint	✅​p	🔄​f	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p	✅​p

[pietern]

Are they mapped exclusively into the new values? (no possibility we need to flip?)

@denik Other concerns with this?

[pietern]

Separate reason in the plan would be nice. Can be separate PR.