Merged
Conversation
Collaborator
|
Commit: 7de61e4
15 failing tests:
Top 25 slowest tests (at least 2 minutes):
|
900c30b to
54e0bab
Compare
d00f343 to
0f1d24c
Compare
00025d4 to
bd5cb0a
Compare
665ab46 to
546d9f8
Compare
6317768 to
3e06c6a
Compare
f5457b4 to
cb1ecd3
Compare
cb1ecd3 to
8926051
Compare
3e44d15 to
e457ff8
Compare
e457ff8 to
d84d6c1
Compare
Co-authored-by: Pieter Noordhuis <pieter.noordhuis@databricks.com>
Contributor
|
partial review, I still need to review the acceptance tests. |
pietern
approved these changes
Nov 27, 2025
cmd/bundle/deployment/migrate.go
Outdated
| if stateDesc.Lineage == "" { | ||
| cmdio.LogString(ctx, `This command migrates the existing Terraform state file (terraform.tfstate) to a direct deployment state file (resources.json). However, no existing local or remote state was found. | ||
|
|
||
| To start using direct engine, deploy with DATABRICKS_BUNDLE_ENGINE=direct env var set.`) // TODO: mention bundle.engine once it's there |
Contributor
There was a problem hiding this comment.
Easy to miss when eyeballing a page of code.
Collaborator
|
Commit: 33fadff
40 failing tests:
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
New migrate command to convert terraform state to direct engine state.
Depends on #3875
Tests
Acceptance tests.
Extended print_state.py utility to accept -t/--target and --backup args.