-
Notifications
You must be signed in to change notification settings - Fork 112
[Python] Generate code for apps #3852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
73 failing tests:
|
| AppResourceDatabaseDict, | ||
| AppResourceDatabaseParam, | ||
| ) | ||
| from databricks.bundles.apps._models.app_resource_database_database_permission import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are a bunch of fields with repetition app_resource_database_database_permission, app_resource_genie_space_genie_space_permission, ...
| AppDeploymentArtifactsDict, | ||
| AppDeploymentArtifactsParam, | ||
| ) | ||
| from databricks.bundles.apps._models.app_deployment_mode import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be exposed but I assume this comes from the protos
|
|
||
| source_code_path: VariableOr[str] | ||
|
|
||
| active_deployment: VariableOrOptional[AppDeployment] = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like a computed field
| to the app compute. | ||
| """ | ||
|
|
||
| app_status: VariableOrOptional[ApplicationStatus] = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
| The description of the app. | ||
| """ | ||
|
|
||
| effective_budget_policy_id: VariableOrOptional[str] = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also output only
|
|
||
|
|
||
| @dataclass(kw_only=True) | ||
| class AppDeployment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need AppDeployment. This should be handled directly by DABs
d4d15c5 to
e0d3bac
Compare
Changes
Why
Tests