Automatically sign CLI binary using Goreleaser #3879
+92
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnester
requested review from
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
6 failing tests:
|
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
commented
Nov 10, 2025
| with: | ||
| packages-dir: experimental/python/dist | ||
|
|
||
| publish-to-winget-pkgs: |
Contributor
Author
There was a problem hiding this comment.
This action moved from publish-winget.yml which was previously manually triggered, now it triggered automatically after goreleaser succeeds.
andrewnester
commented
Nov 10, 2025
| urls=$( | ||
| gh api https://api.github.com/repos/databricks/cli/releases/tags/${{ github.ref_name }} | \ | ||
| jq -r .assets[].browser_download_url | \ | ||
| grep -E '_windows_.*\.zip$' | \ |
Contributor
Author
There was a problem hiding this comment.
The only change it used to search for -signed suffixed archives, but nowthe default named archive for windows is already signed
pietern
reviewed
Nov 10, 2025
| -p ${{ secrets.DECO_SIGN_AZURE_CLIENT_SECRET }} \ | ||
| --tenant ${{ secrets.DECO_SIGN_AZURE_TENANT_ID }} | ||
| ACCESS_TOKEN=$(az account get-access-token --resource https://vault.azure.net --query accessToken -o tsv) | ||
| echo "ACCESS_TOKEN=$ACCESS_TOKEN" >> $GITHUB_ENV |
Contributor
There was a problem hiding this comment.
We need to mark this as secret/sensitive as well.
| hooks: | ||
| post: | ||
| - sh -c 'if [ "{{ .Os }}" = "windows" ]; then java -jar /tmp/jsign.jar --storetype AZUREKEYVAULT --keystore "${AZURE_KEY_VAULT_NAME}" --storepass "${ACCESS_TOKEN}" --alias "${AZURE_CERTIFICATE_NAME}" --tsaurl http://timestamp.digicert.com "{{ .Path }}"; fi' | ||
|
|
Contributor
There was a problem hiding this comment.
This looks a bit finicky. Is this the recommended approach with goreleaser?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Automatically sign CLI binary using Goreleaser
Why
Currently, it's a manual process; we want it to be automatic
Tests
Successful dry-run is here: https://github.com/databricks/cli/actions/runs/19235669891/job/54984805490