-
Notifications
You must be signed in to change notification settings - Fork 112
direct: Add permissions support for dashboards #3882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
57 failing tests:
|
acceptance/bundle/resources/permissions/dashboards/create/script
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,3 @@ | |||
| Local = false | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not run this test locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cloud identity is a service principal, but the local identity is a username. That shows up in the permissions request body.
It was easiest to just run the test on the cloud. Otherwise we'll need separate golden files for local and cloud.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have IsServicePrincipal = true setting in test.toml for such cases. This makes test runner set up service-principal-like identity locally.
Tested using new acceptance tests.