Conversation
Collaborator
19 failing tests:
|
1838a00 to
6108a29
Compare
acceptance/bundle/resources/grants/registered_models/databricks.yml.tmpl
Show resolved
Hide resolved
acceptance/bundle/resources/grants/schemas/empty_array/out.deploy1.requests.direct.json
Show resolved
Hide resolved
acceptance/bundle/resources/grants/volumes/out.deploy1.requests.direct.json
Show resolved
Hide resolved
shreyas-goenka
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add grants support for all resources that have Grants in the schema (schemas, models, registered_models).
The approach is different from terraform, rather than doing get + update, we do a single update where we clear all existing permissions.
Tests
Acceptance cloud tests. Since we cannot compare requests between direct and terraform (but still record them), we test by fetching final grants after deploy from the backend.
Extended testserver to support grants. Added a bunch of fields to schemas and volumes to make it looks more like real API.