Skip to content

direct: grants support#3883

Merged
denik merged 32 commits intomainfrom
denik/grants-direct
Nov 7, 2025
Merged

direct: grants support#3883
denik merged 32 commits intomainfrom
denik/grants-direct

Conversation

@denik
Copy link
Contributor

@denik denik commented Nov 5, 2025

Changes

Add grants support for all resources that have Grants in the schema (schemas, models, registered_models).

The approach is different from terraform, rather than doing get + update, we do a single update where we clear all existing permissions.

Tests

Acceptance cloud tests. Since we cannot compare requests between direct and terraform (but still record them), we test by fetching final grants after deploy from the backend.

Extended testserver to support grants. Added a bunch of fields to schemas and volumes to make it looks more like real API.

@denik denik temporarily deployed to test-trigger-is November 5, 2025 16:07 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is November 5, 2025 16:10 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is November 5, 2025 16:11 — with GitHub Actions Inactive
@eng-dev-ecosystem-bot
Copy link
Collaborator

eng-dev-ecosystem-bot commented Nov 5, 2025

Run: 19168707285

Env 🔄​flaky 💚​RECOVERED 🙈​SKIP ✅​pass 🙈​skip
🔄​ aws linux 6 1 1 350 599
💚​ aws windows 1 1 357 598
💚​ aws-ucws linux 1 1 491 490
🔄​ aws-ucws windows 1 1 1 491 489
🔄​ azure linux 3 1 1 353 598
🔄​ azure windows 3 1 355 597
💚​ azure-ucws linux 1 1 487 489
🔄​ azure-ucws windows 2 1 1 486 488
🔄​ gcp linux 2 1 1 353 600
🔄​ gcp windows 1 1 1 355 599
19 failing tests:
Test Name aws linux aws windows aws-ucws linux aws-ucws windows azure linux azure windows azure-ucws linux azure-ucws windows gcp linux gcp windows
TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 🔄​f 💚​R 💚​R 💚​R 💚​R
TestAccept/bundle/destroy/jobs-and-pipeline ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f ✅​p ✅​p ✅​p ✅​p
TestAccept/bundle/destroy/jobs-and-pipeline/DATABRICKS_BUNDLE_ENGINE=direct ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f ✅​p ✅​p ✅​p ✅​p
TestAccept/bundle/run/app-with-job 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=direct/DLT=no/NBOOK=no/PY=no 🔄​f ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=direct/DLT=no/NBOOK=no/PY=yes 🔄​f ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=direct/DLT=no/NBOOK=yes/PY=yes 🔄​f ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=direct/DLT=yes/NBOOK=no/PY=no 🔄​f ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=direct/DLT=yes/NBOOK=yes/PY=no 🔄​f ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=direct/DLT=yes/NBOOK=yes/PY=yes 🔄​f ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=terraform/DLT=no/NBOOK=no/PY=yes ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f ✅​p
TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=terraform/DLT=no/NBOOK=yes/PY=no ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f ✅​p
TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_BUNDLE_ENGINE=direct/UV_PYTHON=3.11 ✅​p ✅​p ✅​p ✅​p 🔄​f ✅​p ✅​p ✅​p ✅​p ✅​p
TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_BUNDLE_ENGINE=direct/UV_PYTHON=3.12 ✅​p ✅​p ✅​p ✅​p 🔄​f ✅​p ✅​p ✅​p ✅​p ✅​p
TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_BUNDLE_ENGINE=direct/UV_PYTHON=3.13 ✅​p ✅​p ✅​p ✅​p 🔄​f ✅​p ✅​p ✅​p ✅​p ✅​p
TestGenerateFromExistingPipelineAndDeploy ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f
TestSyncEnsureRemotePathIsUsableIfRepoExists ✅​p ✅​p ✅​p 🔄​f ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
TestFilerRecursiveDelete ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f ✅​p ✅​p
TestFilerRecursiveDelete/files 🙈​s 🙈​s ✅​p ✅​p 🙈​s 🙈​s ✅​p 🔄​f 🙈​s 🙈​s

@denik denik temporarily deployed to test-trigger-is November 5, 2025 17:01 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is November 6, 2025 15:04 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is November 6, 2025 16:11 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is November 6, 2025 16:41 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is November 6, 2025 17:25 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is November 6, 2025 17:29 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is November 6, 2025 17:31 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is November 6, 2025 17:45 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is November 6, 2025 17:54 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is November 7, 2025 08:52 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is November 7, 2025 08:57 — with GitHub Actions Inactive
@denik denik changed the title WIP grants support in direct direct: grants support Nov 7, 2025
@denik denik temporarily deployed to test-trigger-is November 7, 2025 09:38 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is November 7, 2025 10:19 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is November 7, 2025 10:22 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is November 7, 2025 10:24 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is November 7, 2025 10:30 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is November 7, 2025 10:35 — with GitHub Actions Inactive
@denik denik force-pushed the denik/grants-direct branch from 1838a00 to 6108a29 Compare November 7, 2025 10:36
@denik denik temporarily deployed to test-trigger-is November 7, 2025 10:36 — with GitHub Actions Inactive
@denik denik marked this pull request as ready for review November 7, 2025 10:38
@denik denik temporarily deployed to test-trigger-is November 7, 2025 10:42 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is November 7, 2025 11:06 — with GitHub Actions Inactive
@denik denik temporarily deployed to test-trigger-is November 7, 2025 12:42 — with GitHub Actions Inactive
@denik denik requested a review from shreyas-goenka November 7, 2025 14:04
@denik denik added this pull request to the merge queue Nov 7, 2025
Merged via the queue into main with commit 8d41fe3 Nov 7, 2025
13 checks passed
@denik denik deleted the denik/grants-direct branch November 7, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments