-
Notifications
You must be signed in to change notification settings - Fork 112
Add default-minimal template #3885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+541
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add minimal template positioned after default-sql in CLI selection - Provides only essential infrastructure: databricks.yml, pyproject.toml, README, empty src/ and resources/ directories, and basic test setup - Welcome message emphasizes this is for advanced users and recommends default-python/default-sql for those getting started - Template reuses default template structure via "template_dir": "../default" - Equivalent to default-python when answering "no" to all sample content prompts - Renderer improvements: preserve empty directories without needing .gitkeep files Users need a clean starting point for building bundles from scratch without sample code getting in the way. Advanced users know what they want to build and don't need the training wheels of sample notebooks and pipelines. - All template acceptance tests pass, including new default-minimal tests - Verified template instantiation creates correct directory structure 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Updates the default-minimal template to be fully consistent with the default-python template structure: - Remove project_name_short property (not used in minimal template) - Fix property order numbering (1-10) to match default-python - Update property descriptions to match default-python exactly - Improve welcome message: "For getting started with Python or SQL code..." - Add // comments to hidden properties for clarity - Fix default_catalog to use hive_metastore fallback like default-python These changes ensure users have a consistent experience across all default templates while maintaining the minimal template's purpose of providing a clean starting point without sample code. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
When templates have no Python package directory (include_python=no AND no jobs/pipelines, OR lakeflow_only=yes), hatch cannot automatically detect what to build. This causes 'uv run pytest' to fail with build errors: "Unable to determine which files to ship inside the wheel using the following heuristics: <https://hatch.pypa.io/latest/plugins/builder/wheel/#default-file-selection>" Add conditional [tool.hatch.build.targets.wheel] configuration with packages = ["src"] when $has_python_package_dir is false. This matches the same logic used in __preamble.tmpl to determine directory structure. The fix applies to: - default-minimal template (no sample code) - lakeflow-pipelines templates (SQL-only, no Python packages) This ensures 'uv run pytest' works correctly in all template variants. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Collaborator
10 failing tests:
|
pietern
reviewed
Nov 6, 2025
Contributor
pietern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
lennartkats-db
added a commit
that referenced
this pull request
Nov 7, 2025
- Simplified PR description to be more concise - Added changelog entry for default-minimal template (#3885) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Contributor
|
@lennartkats-db Love it |
pietern
approved these changes
Nov 10, 2025
…n default-minimal template Addresses PR feedback to verify that the template renderer correctly preserves empty directories without requiring .gitkeep files. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds a new
default-minimaltemplate for advanced users who want a clean slate without sample code:default-minimalwhich inherits from thedefaulttemplate, just likedefault-python.gitkeepfiles insrc/andresources/)uv run pytesterror shown for projects that don't have asrc/<package>directoryWhy
Advanced customers and non-ETL customers (like @fjakobs) indicated they want an "empty" or "minimal" project template where they don't need to delete sample code. Rather than answering "no" to all questions in
default-python, this gives them something more intentional.Tests
Example: