DAB unable to validate container local file:///path-to-jar #3892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshpuntoff
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
## Changes
In a runtime container, I need to be able to reference files.
This PR allows the
file:///path (which is valid in databricks templates) to do that.Currently the CLI attempts to resolve this path when it should now.
Open to feedback here.
Why
When running a containerized job, I have pre-bundled assets that need to be referenced.
If I set the path to
file:///manually via the databricks UX, my job works. If I attempt to do it via the cli, I have this rendering issue.With this change, the asset bundle is deployable.
Tests
Unit testing and manual deployment verification.