Pass template name to README for templates that inherit from 'default' - #3893
Merged
Conversation
lennartkats-db
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
November 7, 2025 07:40
lennartkats-db
temporarily deployed
to
test-trigger-is
November 7, 2025 07:40 — with
GitHub Actions
Inactive
Collaborator
9 failing tests:
Top 50 slowest tests (at least 2 minutes):
|
lennartkats-db
enabled auto-merge
November 10, 2025 19:55
pietern
approved these changes
Nov 11, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 11, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 13, 2025
lennartkats-db
temporarily deployed
to
test-trigger-is
November 14, 2025 18:06 — with
GitHub Actions
Inactive
The default, default-python, pydabs, and lakeflow-pipelines templates now correctly display their template name in the generated README instead of always saying 'default template'.
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
lennartkats-db
force-pushed
the
fix-template-name-in-readme
branch
from
November 14, 2025 20:53
a14de3b to
a010f42
Compare
lennartkats-db
temporarily deployed
to
test-trigger-is
November 14, 2025 20:53 — with
GitHub Actions
Inactive
lennartkats-db
temporarily deployed
to
test-trigger-is
November 15, 2025 08:02 — with
GitHub Actions
Inactive
andrewnester
approved these changes
Nov 18, 2025
Collaborator
|
Commit: 079891f
13 failing tests:
Top 50 slowest tests (at least 2 minutes):
|
denik
pushed a commit
that referenced
this pull request
May 20, 2026
#3893) ## Changes The default, default-python, pydabs, and lakeflow-pipelines templates now correctly display their template name in the generated README instead of always saying 'default template'. ## Why Showing the actual template name to customers seems helpful, even if it comes at the cost of a bit of extra code in the template. ## Tests Standard template acceptance tests --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The default, default-python, pydabs, and lakeflow-pipelines templates now correctly display their template name in the generated README instead of always saying 'default template'.
Why
Showing the actual template name to customers seems helpful, even if it comes at the cost of a bit of extra code in the template.
Tests
Standard template acceptance tests