Update templates to use serverless environment version 4 and matching Python version #3897
+57
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the Python version spec changes from experimental-jobs-as-code template to minimize the diff. This template doesn't need the same Python version constraints as the default template. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
lennartkats-db
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
12 failing tests:
|
pietern
approved these changes
Nov 10, 2025
| * This needs to be compatible with the version of DB Connect and the serverless_environment_version. | ||
| */}} | ||
| {{define "python_version_spec" -}} | ||
| >=3.10,<3.13 |
Contributor
There was a problem hiding this comment.
As this is the only spot where the local Python version is specified, could you copy the rationale from the PR summary here? I was wondering when seeing this line before reading the PR summary.
Contributor
Author
There was a problem hiding this comment.
Yes, good feedback.
Expands the python_version_spec comment to explain why we use >=3.10,<3.13 rather than pinning to 3.12. The broader range improves usability by avoiding the need for version managers while maintaining compatibility with DB Connect 15, serverless environment v4/v5, and DBR 16/17. Addresses PR feedback: #3897 (review) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This updates templates to serverless environment version 4 and associated Python versions
Some considerations:
Why
Tests