-
Notifications
You must be signed in to change notification settings - Fork 125
Granular updates for model serving endpoints #3988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8f26a22 to
fd244e3
Compare
Collaborator
|
Commit: 9641e1c
12 failing tests:
Top 26 slowest tests (at least 2 minutes):
|
- Merged latest main branch which renamed DoUpdateWithChanges to DoUpdate - DoUpdate now has same signature with changes parameter - Updated all resource implementations to use DoUpdate - All model serving endpoint tests still passing
- Added 'type Changes = deployplan.Changes' alias in alert.go (same as main) - Updated all DoUpdate signatures to use *Changes instead of *deployplan.Changes - Removed unused deployplan imports where only the alias is used - Reduces diff with main branch
denik
reviewed
Nov 27, 2025
acceptance/bundle/resources/model_serving_endpoints/update/ai-gateway/script
Show resolved
Hide resolved
denik
reviewed
Dec 1, 2025
denik
reviewed
Dec 1, 2025
denik
approved these changes
Dec 2, 2025
Collaborator
|
Commit: e57befa
44 failing tests:
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR implements granular updates for model serving endpoints. Instead of always updating the entire endpoint configuration, the CLI now only sends updates for the specific fields that have changed. This are:
Why
Model serving endpoint updates are expensive operations. By sending only the changed fields, we reduce the scope of updates and improve deployment performance.
We also don't have guarentees that these API calls are safe to do in parallel. This matches the TF implementation: https://github.com/databricks/terraform-provider-databricks/blob/b0a2a1c6a1688498fd6a00c64003ef4948da21e8/serving/resource_model_serving.go#L366
Tests
Added comprehensive acceptance tests for various update scenarios:
Note: This PR depends on #3995 and should be merged after that PR is merged and this branch is rebased.
Note: These tests are local only because model serving endpoints take a long time (~30 minutes) to spin up and can be flaky. We can confirm though that the TF and DABs behavior matches.