Wait for cleanup in ssh-tunnel tests #4028

ilia-db · 2025-11-28T09:37:48Z

Changes

That wouldn't fix the tests, but should make it easier to debug

Why

Tests

experimental/ssh/internal/proxy/proxy_test.go

eng-dev-ecosystem-bot · 2025-11-28T10:00:52Z

Commit: 7916df3

Run: 19818287103

	Env	❌FAIL	🟨KNOWN	🔄flaky	💚RECOVERED	🙈SKIP	✅pass	🙈skip	Time
🔄	aws linux			10	7	2	361	628	23:15
❌	aws windows	15	1		6	2	358	626	15:52
🔄	aws-ucws linux			3	4	2	514	513	21:36
💚	aws-ucws windows				7	2	516	511	19:57
🔄	azure linux			9	1	4	362	627	27:30
🔄	azure windows			7	1	4	366	625	20:45
💚	azure-ucws linux				1	4	510	512	20:51
💚	azure-ucws windows				1	4	512	510	22:48
💚	gcp linux				1	4	364	631	17:57
🔄	gcp windows			4	1	4	362	629	16:52

34 failing tests:

	Test Name	aws linux	aws windows	aws-ucws linux	aws-ucws windows	azure linux	azure windows	azure-ucws linux	azure-ucws windows	gcp linux	gcp windows
🟨	TestAccept	💚R	🟨K	🔄f	💚R	💚R	💚R	💚R	💚R	💚R	💚R
❌	TestAccept/bundle/destroy/jobs-and-pipeline	✅p	❌F	✅p	✅p	🔄f	✅p	✅p	✅p	✅p	✅p
❌	TestAccept/bundle/destroy/jobs-and-pipeline/DATABRICKS_BUNDLE_ENGINE=direct	✅p	❌F	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/destroy/jobs-and-pipeline/DATABRICKS_BUNDLE_ENGINE=terraform	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p	✅p
🙈	TestAccept/bundle/resources/permissions	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🔄	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions	💚R	💚R	🔄f	💚R	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🔄	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions/DATABRICKS_BUNDLE_ENGINE=direct	💚R	💚R	🔄f	💚R
💚	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions/DATABRICKS_BUNDLE_ENGINE=terraform	💚R	💚R	💚R	💚R
💚	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions	💚R	💚R	💚R	💚R	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
💚	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions/DATABRICKS_BUNDLE_ENGINE=direct	💚R	💚R	💚R	💚R
💚	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions/DATABRICKS_BUNDLE_ENGINE=terraform	💚R	💚R	💚R	💚R
🙈	TestAccept/bundle/run/app-with-job	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
❌	TestAccept/bundle/templates/default-python/combinations/classic	✅p	❌F	✅p	✅p	✅p	✅p	✅p	✅p	✅p	🔄f
❌	TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=direct/DLT=no/NBOOK=no/PY=no	🔄f	❌F	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=direct/DLT=no/NBOOK=no/PY=yes	🔄f	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p
❌	TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=direct/DLT=no/NBOOK=yes/PY=no	🔄f	❌F	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=direct/DLT=no/NBOOK=yes/PY=yes	✅p	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=direct/DLT=yes/NBOOK=no/PY=no	🔄f	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=direct/DLT=yes/NBOOK=no/PY=yes	✅p	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=direct/DLT=yes/NBOOK=yes/PY=no	✅p	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p
❌	TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=direct/DLT=yes/NBOOK=yes/PY=yes	🔄f	❌F	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=terraform/DLT=yes/NBOOK=yes/PY=no	✅p	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p
❌	TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=terraform/DLT=yes/NBOOK=yes/PY=yes	🔄f	❌F	✅p	✅p	✅p	✅p	✅p	✅p	✅p	🔄f
❌	TestAccept/bundle/templates/default-python/integration_classic	✅p	❌F	✅p	✅p	✅p	✅p	✅p	✅p	✅p	🔄f
❌	TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_BUNDLE_ENGINE=direct/UV_PYTHON=3.10	✅p	❌F	✅p	✅p	🔄f	✅p	✅p	✅p	✅p	✅p
❌	TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_BUNDLE_ENGINE=direct/UV_PYTHON=3.11	✅p	❌F	✅p	✅p	🔄f	✅p	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_BUNDLE_ENGINE=direct/UV_PYTHON=3.12	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_BUNDLE_ENGINE=terraform/UV_PYTHON=3.10	🔄f	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p	🔄f
❌	TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_BUNDLE_ENGINE=terraform/UV_PYTHON=3.11	🔄f	❌F	✅p	✅p	🔄f	✅p	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_BUNDLE_ENGINE=terraform/UV_PYTHON=3.12	🔄f	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p	✅p
❌	TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_BUNDLE_ENGINE=terraform/UV_PYTHON=3.13	🔄f	❌F	✅p	✅p	🔄f	✅p	✅p	✅p	✅p	✅p
❌	TestAccept/selftest/record_cloud/pipeline-crud	✅p	❌F	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p
❌	TestAccept/selftest/record_cloud/pipeline-crud/DATABRICKS_BUNDLE_ENGINE=direct	✅p	❌F	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p
❌	TestAccept/selftest/record_cloud/pipeline-crud/DATABRICKS_BUNDLE_ENGINE=terraform	✅p	❌F	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p

Top 21 slowest tests (at least 2 minutes):

duration	env	testname
6:23	aws-ucws linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:57	aws-ucws linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:54	aws linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:46	gcp linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:44	gcp linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:40	aws windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:38	aws linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:35	gcp windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:33	aws windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:27	aws-ucws windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:16	gcp windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
4:05	azure-ucws windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
4:04	azure-ucws linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
3:52	azure-ucws windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
3:42	azure linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
3:40	azure linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
3:08	azure-ucws windows	TestAccept/bundle/resources/synced_database_tables/basic
2:30	azure-ucws linux	TestAccept/bundle/resources/synced_database_tables/basic
2:25	azure-ucws linux	TestAccept
2:11	gcp linux	TestAccept
2:01	aws-ucws windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform

pietern · 2025-11-28T14:17:54Z

@ilia-db The test failure looks related (or similar):

=== Failed
=== FAIL: experimental/ssh/internal/proxy TestConnectionsManager_TryAdd_Success (unknown)
2025/11/28 09:44:14 INFO SSHD process exited with state: signal: killed, <nil> session=266a6b99-f00e-4851-85c7-e507556e928f
panic: Fail in goroutine after TestQuickHandover has completed

goroutine 171 [running]:
testing.(*common).Fail(0xc0005b1a40)
	/opt/hostedtoolcache/go/1.25.1/x64/src/testing/testing.go:960 +0xca
testing.(*common).Errorf(0xc0005b1a40, {0xe0b776?, 0xf4e620?}, {0xc0004bafb0?, 0xf4e760?, 0xc000130700?})
	/opt/hostedtoolcache/go/1.25.1/x64/src/testing/testing.go:1205 +0x59
github.com/databricks/cli/experimental/ssh/internal/proxy.createTestClient.func3()
	/home/runner/work/cli/cli/experimental/ssh/internal/proxy/client_server_test.go:55 +0xd8
created by github.com/databricks/cli/experimental/ssh/internal/proxy.createTestClient in goroutine 169
	/home/runner/work/cli/cli/experimental/ssh/internal/proxy/client_server_test.go:49 +0x30d

Wait for cleanup in ssh-tunnel tests

dd15c85

ilia-db requested review from andrewnester, anton-107, denik, pietern and shreyas-goenka as code owners November 28, 2025 09:37

ilia-db temporarily deployed to test-trigger-is November 28, 2025 09:37 — with GitHub Actions Inactive

pietern reviewed Nov 28, 2025

View reviewed changes

experimental/ssh/internal/proxy/proxy_test.go Show resolved Hide resolved

pietern approved these changes Nov 28, 2025

View reviewed changes

Fix tests for client_server_test.go and proxy_test.go

44ad29d

ilia-db temporarily deployed to test-trigger-is November 28, 2025 15:28 — with GitHub Actions Inactive

Guard against io.ErrClosedPipe in test server

0b90fdb

ilia-db temporarily deployed to test-trigger-is November 28, 2025 15:31 — with GitHub Actions Inactive

Merge branch 'main' into ssh-tunnel-wait-for-cleanup-in-tests

7916df3

ilia-db temporarily deployed to test-trigger-is December 1, 2025 09:46 — with GitHub Actions Inactive

ilia-db enabled auto-merge December 1, 2025 09:52

ilia-db added this pull request to the merge queue Dec 1, 2025

Merged via the queue into main with commit 137b596 Dec 1, 2025
13 checks passed

ilia-db deleted the ssh-tunnel-wait-for-cleanup-in-tests branch December 1, 2025 11:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Wait for cleanup in ssh-tunnel tests #4028

Wait for cleanup in ssh-tunnel tests #4028

Uh oh!

ilia-db commented Nov 28, 2025

Uh oh!

Uh oh!

eng-dev-ecosystem-bot commented Nov 28, 2025 •

edited

Loading

Uh oh!

pietern commented Nov 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Wait for cleanup in ssh-tunnel tests #4028

Wait for cleanup in ssh-tunnel tests #4028

Uh oh!

Conversation

ilia-db commented Nov 28, 2025

Changes

Why

Tests

Uh oh!

Uh oh!

eng-dev-ecosystem-bot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pietern commented Nov 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

eng-dev-ecosystem-bot commented Nov 28, 2025 •

edited

Loading