-
Notifications
You must be signed in to change notification settings - Fork 139
direct: pipelines: Ignore run_as change from the backend #4037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| bundle: | ||
| name: dabs_revenue-$UNIQUE_NAME | ||
|
|
||
| permissions: | ||
| - level: CAN_VIEW | ||
| group_name: users | ||
|
|
||
| resources: | ||
| pipelines: | ||
| foo: | ||
| name: DABs Revenue Pipeline | ||
|
|
||
| libraries: | ||
| - notebook: | ||
| path: sql.sql | ||
|
|
||
| serverless: true | ||
|
|
||
| targets: | ||
| development: | ||
| default: true | ||
| mode: development | ||
|
|
||
| resources: | ||
| pipelines: | ||
| # Make the pipeline write to the current user's schema in logfood. | ||
| foo: | ||
| catalog: users | ||
| target: ${workspace.current_user.short_name} | ||
|
|
||
| production: | ||
| run_as: | ||
| service_principal_name: $TEST_SP_APPLICATION_ID | ||
|
|
||
| resources: | ||
| pipelines: | ||
| # Make the pipeline write to the team's schema in logfood. | ||
| foo: | ||
| catalog: main | ||
| target: team_eng_deco |
Empty file.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
|
|
||
| >>> DATABRICKS_BUNDLE_ENGINE=terraform [CLI] bundle plan -t production | ||
| Recommendation: permissions section should explicitly include the current deployment identity '[USERNAME]' or one of its groups | ||
| If it is not included, CAN_MANAGE permissions are only applied if the present identity is used to deploy. | ||
|
|
||
| Consider using a adding a top-level permissions section such as the following: | ||
|
|
||
| permissions: | ||
| - user_name: [USERNAME] | ||
| level: CAN_MANAGE | ||
|
|
||
| See https://docs.databricks.com/dev-tools/bundles/permissions.html to learn more about permission configuration. | ||
| in databricks.yml:5:3 | ||
|
|
||
| create pipelines.foo | ||
| create pipelines.foo.permissions | ||
|
|
||
| Plan: 2 to add, 0 to change, 0 to delete, 0 unchanged | ||
|
|
||
| >>> DATABRICKS_BUNDLE_ENGINE=terraform [CLI] bundle deploy -t production | ||
| Recommendation: permissions section should explicitly include the current deployment identity '[USERNAME]' or one of its groups | ||
| If it is not included, CAN_MANAGE permissions are only applied if the present identity is used to deploy. | ||
|
|
||
| Consider using a adding a top-level permissions section such as the following: | ||
|
|
||
| permissions: | ||
| - user_name: [USERNAME] | ||
| level: CAN_MANAGE | ||
|
|
||
| See https://docs.databricks.com/dev-tools/bundles/permissions.html to learn more about permission configuration. | ||
| in databricks.yml:5:3 | ||
|
|
||
| Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/dabs_revenue-[UNIQUE_NAME]/production/files... | ||
| Deploying resources... | ||
| Updating deployment state... | ||
| Deployment complete! | ||
|
|
||
| >>> print_requests.py //pipelines | ||
| File [TEST_TMP_DIR]/out.requests.txt not found | ||
|
|
||
| >>> [CLI] bundle destroy --auto-approve | ||
| Recommendation: permissions section should explicitly include the current deployment identity '[USERNAME]' or one of its groups | ||
| If it is not included, CAN_MANAGE permissions are only applied if the present identity is used to deploy. | ||
|
|
||
| Consider using a adding a top-level permissions section such as the following: | ||
|
|
||
| permissions: | ||
| - user_name: [USERNAME] | ||
| level: CAN_MANAGE | ||
|
|
||
| See https://docs.databricks.com/dev-tools/bundles/permissions.html to learn more about permission configuration. | ||
| in databricks.yml:5:3 | ||
|
|
||
| No active deployment found to destroy! | ||
|
|
||
| Exit code: 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| if [ -z "${TEST_SP_APPLICATION_ID+x}" ]; then | ||
| export TEST_SP_APPLICATION_ID="123b0db3-ba48-4e12-be3b-3b7898cdf000" | ||
| fi | ||
|
|
||
| envsubst < databricks.yml.tmpl > databricks.yml | ||
| trace DATABRICKS_BUNDLE_ENGINE=terraform $CLI bundle plan -t production | ||
|
|
||
| cleanup() { | ||
| trace $CLI bundle destroy --auto-approve | ||
| } | ||
|
|
||
|
|
||
| trap cleanup EXIT | ||
|
|
||
| trace DATABRICKS_BUNDLE_ENGINE=terraform $CLI bundle deploy -t production | ||
| trace print_requests.py //pipelines > out.create_requests.json | ||
| trace print_state.py -t production > out.old_state.json | ||
|
|
||
| pipeline_id=$($CLI bundle summary -t production --output json | jq -r '.resources.pipelines.foo.id') | ||
| trace $CLI pipelines get $pipeline_id > out.pipelines_get.json | ||
|
|
||
| trace DATABRICKS_BUNDLE_ENGINE=terraform $CLI bundle plan -t production | ||
| trace DATABRICKS_BUNDLE_ENGINE= $CLI bundle deployment migrate -t production | ||
| trace print_state.py -t production > out.new_state.json | ||
| trace DATABRICKS_BUNDLE_ENGINE= $CLI bundle plan -t production | ||
| trace DATABRICKS_BUNDLE_ENGINE= $CLI bundle plan -t production -o json > out.plan.json | ||
| #trace DATABRICKS_BUNDLE_ENGINE= $CLI bundle deployment deploy -t production | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| -- Databricks notebook source |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Cloud = false | ||
| RecordRequests = false | ||
| Ignore = [".databricks"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.