feat: Update app kit template #4043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarioCadenas
force-pushed
the
update-template
branch
from
25d4cae to
961b511
Compare
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: bcd7e68
9 failing tests:
Top 26 slowest tests (at least 2 minutes):
|
fjakobs
reviewed
Dec 1, 2025
...imental/apps-mcp/templates/appkit/template/{{.project_name}}/config/queries/mocked_sales.sql
Outdated
Show resolved
Hide resolved
|
|
||
| } | ||
|
|
||
| } |
Contributor
Author
There was a problem hiding this comment.
but is missing the schema file for now, I'll add it before marking it as ready
Contributor
Author
There was a problem hiding this comment.
updated, basically we ask the agent to generate a schema for each of the queries in config/queries/schema.ts, and then the appKitTypes file will contain a query registry, so the useAnalyticsQuery will be automatically typed depending on the query.
The pluginRegistry types all the endpoints, we have a bug there that we are fixing, it doesn't generate them when having autoStart as false
Contributor
There was a problem hiding this comment.
not blocking: we need to have an explicit build step as part of npm run build. Today if the agent deploys before running locally we will have an error.
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
requested review from
a team,
lennartkats-db and
pietern
as code owners
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
fjakobs
approved these changes
Dec 1, 2025
|
|
||
| } | ||
|
|
||
| } |
Contributor
There was a problem hiding this comment.
not blocking: we need to have an explicit build step as part of npm run build. Today if the agent deploys before running locally we will have an error.
Collaborator
|
Commit: d277cc4
13 failing tests:
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update the AppKit template to improve the base css, remove some unnecessary code and add some examples of chart usage.
Added a mocked query to show some data on the charts.
Light mode
Dark mode
Why
Tests
Manually