-
Notifications
You must be signed in to change notification settings - Fork 127
Conditionally trigger integration tests based on testmask output #4069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidate integration workflow files into a single job in push.yml that depends on the testmask job introduced in #4017. Integration tests are now only triggered for pull requests when the "test" target is included in the testmask output. When skipped, a success status is posted to satisfy the required check without running tests. This reduces CI resource usage for changes that don't affect code covered by integration tests (e.g., documentation-only changes).
denik
approved these changes
Dec 3, 2025
Collaborator
|
Commit: a65e072
9 failing tests:
Top 18 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: 5eb6dd4
35 failing tests:
Top 50 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: 5eb6dd4
35 failing tests:
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Consolidate integration workflow files into a single job in
push.ymlthat depends on the testmask job introduced in #4017.Integration tests are now only triggered for pull requests when the "test" target is included in the testmask output. When skipped, a success status is posted to satisfy the required check without running tests.
Why
This reduces CI resource usage for changes that don't affect code covered by integration tests (e.g., changes to ./experimental), and reduces the time-to-signal and time-to-merge for those changes.
Tests