Relax default num_workers=0 for job_clusters #4080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
Collaborator
|
Commit: 60eb642
12 interesting tests: 7 KNOWN, 3 flaky, 2 SKIP
Top 22 slowest tests (at least 2 minutes):
|
denik
changed the title
andrewnester
approved these changes
Dec 4, 2025
pietern
reviewed
Dec 4, 2025
| }, | ||
| "job_clusters[0].new_cluster.num_workers": { | ||
| "action": "update", | ||
| "old": 0 |
Contributor
Author
There was a problem hiding this comment.
No, absence is expected.
It's untyped nil internally which is correctly rendered as omitted with omitempty.
Collaborator
|
Commit: cfbf595
20 interesting tests: 11 flaky, 7 KNOWN, 1 SKIP, 1 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Terraform only adds it if neither autoscale nor num_workers are not set. It filters it out if autoscale is set.
Tests
New acceptance test that has different configurations and asserts that requests are the same.
Difference also disappears in existing tests: in default-python recorded requests now have no difference wrt num_workers. In migrate/default-python num_workers no longer triggers drift post migration #4068