Include version in state and plan #4126
Merged
+574
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: e4b79e5
10 interesting tests: 7 KNOWN, 2 flaky, 1 SKIP
Top 24 slowest tests (at least 2 minutes):
|
denik
force-pushed
the
denik/state-version
branch
from
8818ecc to
e7c18da
Compare
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
shreyas-goenka
left a comment
shreyas-goenka
left a comment
There was a problem hiding this comment.
Test review from reviewbot - testing API
Contributor
shreyas-goenka
left a comment
shreyas-goenka
left a comment
There was a problem hiding this comment.
Test review with inline comment
bundle/deployplan/plan.go
Outdated
| return &Plan{ | ||
| Plan: make(map[string]*PlanEntry), | ||
| lockmap: newLockmap(), | ||
| PlanVersion: 1, |
Contributor
There was a problem hiding this comment.
Test inline comment
Contributor
There was a problem hiding this comment.
I was developing a bot to do reviews, these comments are a result of that...
shreyas-goenka
requested changes
Dec 10, 2025
Contributor
shreyas-goenka
left a comment
shreyas-goenka
left a comment
There was a problem hiding this comment.
Good progress on adding version information for debugging and future compatibility. However, there is a critical bug in the migrate command that needs to be addressed.
Additional comments (on lines not in diff):
cmd/bundle/deployment/migrate.go:193
Critical Bug: The migrate command creates a state without setting StateVersion and CLIVersion fields. This means migrated states will have state_version: 0 and cli_version: "", which is inconsistent with newly created states.
bundle/direct/dstate/state.go:106
Suggestion: Consider adding validation after unmarshaling to handle version mismatches.
Review generated by reviewbot
bundle/deployplan/plan.go
Outdated
| return &Plan{ | ||
| Plan: make(map[string]*PlanEntry), | ||
| lockmap: newLockmap(), | ||
| PlanVersion: 1, |
Contributor
There was a problem hiding this comment.
Suggestion: Consider adding a constant for the version number to make it easier to increment in the future.
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
Author
|
good review by bot @shreyas-goenka , please take another look |
shreyas-goenka
approved these changes
Dec 11, 2025
Collaborator
|
Commit: 9e3c449
16 interesting tests: 8 flaky, 7 KNOWN, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Why
Good for debugging. In the future we might want to introduce version 2, this would help.
We'll have to support reading state without the version info though. We don't yet read plans, so once we start doing it (#4094), we can limit ourselves to plan_version==1.