Skip to content

Hide token from console during configuration. #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Hide token from console during configuration. #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5e8ceae
hide the token from the console
andrewmchen May 28, 2018
9cbcfdf
add unit test
andrewmchen May 28, 2018
8622053
Merge branch 'master' into hide-token
andrewmchen Jun 8, 2018
c8bae8a
Merge branch 'master' into hide-token
andrewmchen Aug 7, 2018
da7772b
Merge branch 'master' into hide-token
andrewmchen Aug 7, 2018
331eeb5
fix tests
andrewmchen Jul 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion databricks_cli/configure/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,14 @@

def _configure_cli_token(profile, insecure):
config = ProfileConfigProvider(profile).get_config() or DatabricksConfig.empty()
if config.token:
default_token = '*' * len(config.token)
else:
default_token = None
host = click.prompt(PROMPT_HOST, default=config.host, type=_DbfsHost())
token = click.prompt(PROMPT_TOKEN, default=config.token)
token = click.prompt(PROMPT_TOKEN, default=default_token, hide_input=True)
if token == default_token:
token = config.token
new_config = DatabricksConfig.from_token(host, token, insecure)
update_and_persist_config(profile, new_config)

Expand Down
2 changes: 2 additions & 0 deletions databricks_cli/configure/provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,8 @@ def get_config(self):
class ProfileConfigProvider(DatabricksConfigProvider):
"""Loads from the databrickscfg file."""
def __init__(self, profile=DEFAULT_SECTION):
if profile is None:
profile = DEFAULT_SECTION
self.profile = profile

def get_config(self):
Expand Down
9 changes: 8 additions & 1 deletion tests/configure/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
from click.testing import CliRunner

import databricks_cli.configure.cli as cli
from databricks_cli.configure.provider import get_config, ProfileConfigProvider
from databricks_cli.configure.provider import get_config, ProfileConfigProvider, get_config_for_profile, DEFAULT_SECTION

TEST_HOST = 'https://test.cloud.databricks.com'
TEST_USER = '[email protected]'
Expand Down Expand Up @@ -57,6 +57,13 @@ def test_configure_cli_token():
assert get_config().token == TEST_TOKEN
assert get_config().insecure is None

stdout = runner.invoke(cli.configure_cli, ['--token'],
input=(TEST_HOST + '\n' + '\n')).stdout
assert TEST_TOKEN not in stdout
assert len(TEST_TOKEN) * '*' in stdout
assert get_config().host == TEST_HOST
assert get_config().token == TEST_TOKEN


def test_configure_two_sections():
runner = CliRunner()
Expand Down