API Client timeouts should be int64 (breaks linux_arm target) #1197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayalex
commented
Apr 3, 2025
| ~int | ~int64 | ~float64 | ~float32 | ||
| } | ||
|
|
||
| func orDefault[T number](configured, _default T) T { |
Author
There was a problem hiding this comment.
There are some other users of this function in the package. I opted for generic version so not to change other consumers.
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Implementation uses int(...) for defaults in http timeout configuration, which overflows on linux_arm architecture:
I've changed it to int64 which also matches
time.Durationsize.How is this tested?
PR test suite. Ran build/test locally.
NO_CHANGELOG=true