Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 37 additions & 3 deletions credentials/u2m/cache/file.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,10 @@ func (c *fileTokenCache) Store(key string, t *oauth2.Token) error {
if err != nil {
return fmt.Errorf("marshal: %w", err)
}
return os.WriteFile(c.fileLocation, raw, ownerReadWrite)
if err := c.atomicWriteFile(raw); err != nil {
return fmt.Errorf("error storing token in local cache: %w", err)
}
return nil
}

// Lookup implements the TokenCache interface.
Expand Down Expand Up @@ -151,8 +154,8 @@ func (c *fileTokenCache) init() error {
if err != nil {
return fmt.Errorf("marshal: %w", err)
}
if err := os.WriteFile(c.fileLocation, raw, ownerReadWrite); err != nil {
return fmt.Errorf("write: %w", err)
if err := c.atomicWriteFile(raw); err != nil {
return fmt.Errorf("error creating token cache file: %w", err)
}
}
return nil
Expand All @@ -177,3 +180,34 @@ func (c *fileTokenCache) load() (*tokenCacheFile, error) {
}
return f, nil
}

// atomicWriteFile writes data to the file atomically by first writing to a
// temporary file in the same directory and then renaming it to the target.
// This prevents corruption from interrupted writes.
func (c *fileTokenCache) atomicWriteFile(data []byte) error {
tmp, err := c.writeTmpFile(data)
if err != nil {
return err
}
defer os.Remove(tmp)
return os.Rename(tmp, c.fileLocation)
}

func (c *fileTokenCache) writeTmpFile(data []byte) (string, error) {
tmp, err := os.CreateTemp(filepath.Dir(c.fileLocation), ".token-cache-*.tmp")
if err != nil {
return "", fmt.Errorf("create temp file: %w", err)
}
defer tmp.Close()

if _, err := tmp.Write(data); err != nil {
return "", err
}
if err := tmp.Chmod(ownerReadWrite); err != nil {
return "", err
}
if err := tmp.Close(); err != nil {
return "", err
}
return tmp.Name(), nil
}
Loading