-
Notifications
You must be signed in to change notification settings - Fork 33
Refactor Token Caching with CachedTokenSource Wrapper #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaudhartert-db
approved these changes
Jun 26, 2025
parthban-db
reviewed
Jun 26, 2025
databricks-sdk-java/src/test/java/com/databricks/sdk/core/CliTokenSourceTest.java
Outdated
Show resolved
Hide resolved
parthban-db
reviewed
Jun 26, 2025
Contributor
parthban-db
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM. Left a small comment.
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
parthban-db
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR refactors the token refresh and caching in the Java SDK by:
RefreshableTokenSourceclass that previously handled token refresh and caching logic directlyCachedTokenSourceas a generic wrapper that can be applied to any TokenSource implementationMotivation
Previously, token sources inherited from
RefreshableTokenSourceto gain caching and asynchronous refresh capabilities. However, this inheritance-based approach had limitations when we wanted to make configuration immutable after construction using the builder pattern.The Problem: With abstract classes in Java, constructors are not inherited. To support builder-based configuration, each token source subclass would need to be modified to accept a builder instead of individual parameters, requiring changes across many classes.
The Solution: Switch from inheritance to composition. Instead of inheriting caching behavior, we now wrap any
TokenSourcewhich previously inherited fromRefreshableTokenSourcewithCachedTokenSourceto add caching functionality externally. This allows us to use the builder pattern to configure optional parameters like async refresh and stale duration on each wrapped instance.How is this tested?
This change has been tested with async enabled/disabled by default on existing unit and integration tests.
NO_CHANGELOG=true