Pass Account Id to OAuthClient in External Browser Authentication. #479
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Users with membership in multiple Databricks accounts are sent to an incorrect authorization URL with the external-browser auth type in the Java SDK. Because the new DatabricksConfig created in the OAuthClient doesn't include the account ID so getOidcEndpoints returns endpoints with no account ID in the path. Which redirects it to the default account and not the account that was specified in the intial Config.
How is this tested?
Manually tested that it is not the case anymore using the below code.
The current code is not flexible enough to have unit tests in it and needs a bigger refactor. So, unit tests are not added.
NO_CHANGELOG=true