Skip to content

Conversation

@arjundcunha
Copy link

What changes are proposed in this pull request?

Introduces a new maxRetries configuration option that allows users to override the default retry limit of 4 attempts. This provides greater flexibility for different use cases and network conditions. This is also a feature request here: #289

Changes:

  • Add maxRetries field to DatabricksConfig with DATABRICKS_MAX_RETRIES
    environment variable support
  • Update ApiClient to respect configured maxRetries value
  • Add Builder.withMaxRetries() method for programmatic configuration
  • Include comprehensive test coverage for both programmatic and
    environment variable configuration

Usage:
config.setMaxRetries(10)
or
export DATABRICKS_MAX_RETRIES=10

How is this tested?

Unit tests have been added.

@github-actions
Copy link

Please ensure that the NEXT_CHANGELOG.md file is updated with any relevant changes.
If this is not necessary for your PR, please include the following in your PR description:
NO_CHANGELOG=true
and rerun the job.

@github-actions
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-java

Inputs:

  • PR number: 522
  • Commit SHA: 8e70f89f502785725c30f111ca8bccaa45cb4d2a

Checks will be approved automatically on success.

@renaudhartert-db
Copy link
Contributor

From offline discussion: we are addressing the problem by providing an option to disable retries in this PR #523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants