Add Support for Field Mask in query parameters. #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
rauchy
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Add Support for Field Mask in query parameters.
We are introducing a rich type for FieldMask. This PR ensures that FieldMasks are serialized correctly when used as Query parameters (which is the case for all non batch operations).
Support for FieldMask is added as part of generation framework in a separate PR.
More information about field mask: https://developers.google.com/workspace/slides/api/guides/field-masks
Other Well Known types are not currently supported as query parameters.
Tests are being generated, so they are not part of this PR.
How is this tested?
Chicken and egg problem. We have 3 components, all of which are needed to test this:
Components 1 and 2 are generated and part of another PR. We cannot test this without those components. But at the same time, those components need this change or the generated tests will fail.
I generated locally the SDK with all 3 changes at the same time and run
make test(diff includes many changes. Releavant changes in HttpPathTest.java):https://github.com/databricks/databricks-sdk-java/pull/536/files#diff-e0a2f237fe2b016080aeb672d5793f68486a7b897c7252480c7c00a76f08796f
NO_CHANGELOG=true