-
Notifications
You must be signed in to change notification settings - Fork 33
Correctly return TooManyRequests when receiving HTTP 429 errors.
#547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TooManyRequests when receiving HTTP 429 errors.
…ricks/databricks-sdk-java into api-error
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Divyansh-db
reviewed
Nov 10, 2025
Contributor
Divyansh-db
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had one doubt, otherwise LGTM
databricks-sdk-java/src/main/java/com/databricks/sdk/core/error/ApiErrors.java
Show resolved
Hide resolved
Divyansh-db
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR fixes a bug where the Databricks Java SDK was returning a generic
DatabricksErrorinstead of the specificTooManyRequestsexception for HTTP 429 (Too Many Requests) responses.Key Changes:
Removed hardcoded 429 handling (
ApiErrors.java):DatabricksError("TOO_MANY_REQUESTS", ...). This was likely added as a quick fix in past but resulted in bypassing the existing error mapping infrastructure that would have correctly returned aTooManyRequestsinstance. Now, all HTTP errors (including 429) flow through theErrorMapper, which has the properstatusCode(429, TooManyRequests::new)mapping.Refactored error parsing (
ApiErrors.java):parseApiError()now returnsOptional<ApiErrorBody>to explicitly handle cases where the response body is null or empty.getDatabricksError()passes an emptyApiErrorBodyto theErrorMapper, which correctly infers the error type based solely on the HTTP status code.normalizeError()method to centralize logic for handling older API error formats (API v1.2 and SCIM errors).Simplified error flow (
ApiClient.java):ResponseandExceptiontogetDatabricksError().IOExceptionduring HTTP request execution is now immediately converted toDatabricksError("IO_ERROR", 523, exception)without retry logic.getDatabricksError(Response out, Exception error)togetDatabricksError(Response response).How is this tested?
The change is covered by existing unit tests that have been adapted to verify that 429 error are properly mapped to the right exception.