Skip to content

Fix slow unit tests for FilesExt #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2025
Merged

Fix slow unit tests for FilesExt #1074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
790cff9
fix slow unit tests
mgyucht Oct 14, 2025
4d9a2b5
fix
mgyucht Oct 14, 2025
a66775b
fix
mgyucht Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions databricks/sdk/mixins/files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1337,6 +1337,7 @@ def extended_is_retryable(e: BaseException) -> Optional[str]:
# where we believe request didn't reach the server
is_retryable=extended_is_retryable,
before_retry=before_retry,
clock=self._config.clock,
)(delegate)()

def _open_download_stream(
Expand Down
3 changes: 2 additions & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from databricks.sdk.core import Config
from databricks.sdk.credentials_provider import credentials_strategy

from .clock import FakeClock
from .integration.conftest import restorable_env # type: ignore


Expand All @@ -18,7 +19,7 @@ def noop_credentials(_: any):

@pytest.fixture
def config():
return Config(host="http://localhost", credentials_strategy=noop_credentials)
return Config(host="http://localhost", credentials_strategy=noop_credentials, clock=FakeClock())


@pytest.fixture
Expand Down
Loading