Skip to content

Add retry timeout when fetching oidc_endpoints #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add retry timeout when fetching oidc_endpoints #1085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdb7387
Add retry timeout when fetching oidc_endpoints
rossgray Oct 23, 2025
62d2a07
Update NEXT_CHANGELOG.md
rossgray Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEXT_CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,13 @@
### New Features and Improvements

### Bug Fixes

- Improving the error message that is shown when the unsupported `dbutils.credentials.getServiceCredentialsProvider` method is used. This method can only be used inside of a notebook.

### Documentation

### Internal Changes

- Use the `Config`'s `retry_timeout_seconds` when fetching account and workspace endpoints

### API Changes
10 changes: 7 additions & 3 deletions databricks/sdk/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import requests

from . import useragent
from ._base_client import _fix_host_if_needed
from ._base_client import _BaseClient, _fix_host_if_needed
from .clock import Clock, RealClock
from .credentials_provider import (CredentialsStrategy, DefaultCredentials,
OAuthCredentialsProvider)
Expand Down Expand Up @@ -392,8 +392,12 @@ def oidc_endpoints(self) -> Optional[OidcEndpoints]:
if self.is_azure and self.azure_client_id:
return get_azure_entra_id_workspace_endpoints(self.host)
if self.is_account_client and self.account_id:
return get_account_endpoints(self.host, self.account_id)
return get_workspace_endpoints(self.host)
return get_account_endpoints(
self.host,
self.account_id,
client=_BaseClient(retry_timeout_seconds=self.retry_timeout_seconds)
)
return get_workspace_endpoints(self.host, client=_BaseClient(retry_timeout_seconds=self.retry_timeout_seconds))

def debug_string(self) -> str:
"""Returns log-friendly representation of configured attributes"""
Expand Down