Skip to content

Remove timeout from poll method and LroOptions. #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2025
+5 −5
Merged

Remove timeout from poll method and LroOptions. #1104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ea165e
Remove timeout from poll method and LroOptions.
parthban-db Nov 4, 2025
ae5b4a3
update
parthban-db Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions databricks/sdk/common/lro.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ def __init__(self, *, timeout: Optional[timedelta] = None):
"""
Args:
timeout: The timeout for the Long Running Operations.
If not set, the default timeout is 20 minutes.
Copy link

@Tejas-Kochar Tejas-Kochar Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe update this instead with what happens when a timeout is not provided?
Eg: If not set, then operations do not time out.

Copy link
Contributor Author

@parthban-db parthban-db Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense.

if not set, then operation will wait forever.
"""
self.timeout = timeout or timedelta(minutes=20)
self.timeout = timeout
6 changes: 3 additions & 3 deletions databricks/sdk/retries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def _backoff(attempt: int) -> float:

def poll(
fn: Callable[[], Tuple[Optional[T], Optional[RetryError]]],
timeout: timedelta = timedelta(minutes=20),
timeout: Optional[timedelta] = None,
clock: Optional[Clock] = None,
) -> T:
"""Poll a function until it succeeds or times out.
Expand All @@ -118,7 +118,7 @@ def poll(
Return (None, RetryError.continues("msg")) to continue polling.
Return (None, RetryError.halt(err)) to stop with error.
Return (result, None) on success.
:param timeout: Maximum time to poll (default: 20 minutes)
:param timeout: Maximum time to poll. If None, polls indefinitely.
:param clock: Clock implementation for testing (default: RealClock)
:returns: The result of the successful function call
:raises TimeoutError: If the timeout is reached
Expand All @@ -138,7 +138,7 @@ def check_operation():
if clock is None:
clock = RealClock()

deadline = clock.time() + timeout.total_seconds()
deadline = float("inf") if timeout is None else clock.time() + timeout.total_seconds()
attempt = 0
last_err = None

Expand Down
Loading