Custom scopes support in M2M, WIF and U2M #1194
Open
+249
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tejas-Kochar
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Tejas-Kochar
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Tejas-Kochar
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Tejas-Kochar
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Tejas-Kochar
changed the title
Tejas-Kochar
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Tejas-Kochar
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Tejas-Kochar
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Tejas-Kochar
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Tejas-Kochar
requested review from
hectorcast-db
and removed request for
parthban-db
Contributor
hectorcast-db
left a comment
hectorcast-db
left a comment
There was a problem hiding this comment.
Incremental code is good. Let's add a bit more tests.
|
|
||
| scopes = cfg.get_scopes() | ||
| if not cfg.disable_oauth_refresh_token: | ||
| if "offline_access" not in scopes: |
Contributor
There was a problem hiding this comment.
Let's add a couple of tests to (1) ensure that offline_access is added (2) only if not present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How is this tested?
NO_CHANGELOG=true