[Fix] Include package name for external types when deserializing responses #786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthban-db
approved these changes
Oct 7, 2024
parthban-db
added a commit
that referenced
this pull request
Oct 7, 2024
### Bug Fixes * Fix Model Serving Test ([#781](#781)). * Include package name for external types when deserializing responses ([#786](#786)). ### Internal Changes * Refactor ApiClient into `_BaseClient` and `ApiClient` ([#785](#785)). * Update to latest OpenAPI spec ([#787](#787)). * revert Support Models in `dbutils.fs` operations ([#750](#750)) ([#778](#778)). ### API Changes: * Added [w.disable_legacy_dbfs](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/settings/disable_legacy_dbfs.html) workspace-level service. * Added `default_source_code_path` and `resources` fields for `databricks.sdk.service.apps.App`. * Added `resources` field for `databricks.sdk.service.apps.CreateAppRequest`. * Added `resources` field for `databricks.sdk.service.apps.UpdateAppRequest`. OpenAPI SHA: bc17b474818138f19b78a7bea0675707dead2b87, Date: 2024-10-07
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
### Bug Fixes * Fix Model Serving Test ([#781](#781)). * Include package name for external types when deserializing responses ([#786](#786)). ### Internal Changes * Refactor ApiClient into `_BaseClient` and `ApiClient` ([#785](#785)). * Update to latest OpenAPI spec ([#787](#787)). * revert Support Models in `dbutils.fs` operations ([#750](#750)) ([#778](#778)). ### API Changes: * Added [w.disable_legacy_dbfs](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/settings/disable_legacy_dbfs.html) workspace-level service. * Added `default_source_code_path` and `resources` fields for `databricks.sdk.service.apps.App`. * Added `resources` field for `databricks.sdk.service.apps.CreateAppRequest`. * Added `resources` field for `databricks.sdk.service.apps.UpdateAppRequest`. OpenAPI SHA: bc17b474818138f19b78a7bea0675707dead2b87, Date: 2024-10-07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
#683 is caused by a small bug in the template used to generate the Python SDK. When referring to a class defined in a separate API package, only the module is imported, not the exact class, so the generated code needs to use the qualified name of the structure.
Resolved #683.
Tests
make testrun locallymake fmtapplied