[Fix] Correctly generate classes with nested body fields #808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Test Details: go/deco-tests/11595100355 |
renaudhartert-db
approved these changes
Oct 30, 2024
renaudhartert-db
added a commit
that referenced
this pull request
Nov 4, 2024
### Bug Fixes * Correctly generate classes with nested body fields ([#808](#808)). ### Internal Changes * Add `cleanrooms` package ([#806](#806)). * Add test instructions for external contributors ([#804](#804)). * Always write message for manual test execution ([#811](#811)). * Automatically trigger integration tests on PR ([#800](#800)). * Better isolate ML serving auth unit tests ([#803](#803)). * Move templates in the code generator ([#809](#809)). ### API Changes: * Added [w.aibi_dashboard_embedding_access_policy](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/settings/aibi_dashboard_embedding_access_policy.html) workspace-level service and [w.aibi_dashboard_embedding_approved_domains](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/settings/aibi_dashboard_embedding_approved_domains.html) workspace-level service. * Added [w.credentials](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/credentials.html) workspace-level service. * Added `app_deployment` field for `databricks.sdk.service.apps.CreateAppDeploymentRequest`. * Added `app` field for `databricks.sdk.service.apps.CreateAppRequest`. * Added `app` field for `databricks.sdk.service.apps.UpdateAppRequest`. * Added `table` field for `databricks.sdk.service.catalog.CreateOnlineTableRequest`. * Added `azure_aad` field for `databricks.sdk.service.catalog.GenerateTemporaryTableCredentialResponse`. * Added `full_name` field for `databricks.sdk.service.catalog.StorageCredentialInfo`. * Added `dashboard` field for `databricks.sdk.service.dashboards.CreateDashboardRequest`. * Added `schedule` field for `databricks.sdk.service.dashboards.CreateScheduleRequest`. * Added `subscription` field for `databricks.sdk.service.dashboards.CreateSubscriptionRequest`. * Added `warehouse_id` field for `databricks.sdk.service.dashboards.Schedule`. * Added `dashboard` field for `databricks.sdk.service.dashboards.UpdateDashboardRequest`. * Added `schedule` field for `databricks.sdk.service.dashboards.UpdateScheduleRequest`. * Added `page_token` field for `databricks.sdk.service.oauth2.ListServicePrincipalSecretsRequest`. * Added `next_page_token` field for `databricks.sdk.service.oauth2.ListServicePrincipalSecretsResponse`. * Added `connection_name` field for `databricks.sdk.service.pipelines.IngestionGatewayPipelineDefinition`. * Added `is_no_public_ip_enabled` field for `databricks.sdk.service.provisioning.CreateWorkspaceRequest`. * Added `external_customer_info` and `is_no_public_ip_enabled` fields for `databricks.sdk.service.provisioning.Workspace`. * Added `last_used_day` field for `databricks.sdk.service.settings.TokenInfo`. * Changed `create()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service with new required argument order. * Changed `execute_message_query()` method for [w.genie](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/genie.html) workspace-level service . New request type is `databricks.sdk.service.dashboards.GenieExecuteMessageQueryRequest` dataclass. * Changed `execute_message_query()` method for [w.genie](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/genie.html) workspace-level service to type `execute_message_query()` method for [w.genie](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/genie.html) workspace-level service. * Changed `create()`, `create_schedule()`, `create_subscription()` and `update_schedule()` methods for [w.lakeview](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/lakeview.html) workspace-level service with new required argument order. * Removed [w.clean_rooms](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/clean_rooms.html) workspace-level service. * Removed `deployment_id`, `mode` and `source_code_path` fields for `databricks.sdk.service.apps.CreateAppDeploymentRequest`. * Removed `description`, `name` and `resources` fields for `databricks.sdk.service.apps.CreateAppRequest`. * Removed `description` and `resources` fields for `databricks.sdk.service.apps.UpdateAppRequest`. * Removed `name` and `spec` fields for `databricks.sdk.service.catalog.CreateOnlineTableRequest`. * Removed `display_name`, `parent_path`, `serialized_dashboard` and `warehouse_id` fields for `databricks.sdk.service.dashboards.CreateDashboardRequest`. * Removed `cron_schedule`, `display_name` and `pause_status` fields for `databricks.sdk.service.dashboards.CreateScheduleRequest`. * Removed `subscriber` field for `databricks.sdk.service.dashboards.CreateSubscriptionRequest`. * Removed `display_name`, `etag`, `serialized_dashboard` and `warehouse_id` fields for `databricks.sdk.service.dashboards.UpdateDashboardRequest`. * Removed `cron_schedule`, `display_name`, `etag` and `pause_status` fields for `databricks.sdk.service.dashboards.UpdateScheduleRequest`. * Removed `prev_page_token` field for `databricks.sdk.service.jobs.Run`. OpenAPI SHA: 5285ce76f81314f342c1702d5c2ad4ef42488781, Date: 2024-11-04
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
### Bug Fixes * Correctly generate classes with nested body fields ([#808](#808)). ### Internal Changes * Add `cleanrooms` package ([#806](#806)). * Add test instructions for external contributors ([#804](#804)). * Always write message for manual test execution ([#811](#811)). * Automatically trigger integration tests on PR ([#800](#800)). * Better isolate ML serving auth unit tests ([#803](#803)). * Move templates in the code generator ([#809](#809)). ### API Changes: * Added [w.aibi_dashboard_embedding_access_policy](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/settings/aibi_dashboard_embedding_access_policy.html) workspace-level service and [w.aibi_dashboard_embedding_approved_domains](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/settings/aibi_dashboard_embedding_approved_domains.html) workspace-level service. * Added [w.credentials](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/credentials.html) workspace-level service. * Added `app_deployment` field for `databricks.sdk.service.apps.CreateAppDeploymentRequest`. * Added `app` field for `databricks.sdk.service.apps.CreateAppRequest`. * Added `app` field for `databricks.sdk.service.apps.UpdateAppRequest`. * Added `table` field for `databricks.sdk.service.catalog.CreateOnlineTableRequest`. * Added `azure_aad` field for `databricks.sdk.service.catalog.GenerateTemporaryTableCredentialResponse`. * Added `full_name` field for `databricks.sdk.service.catalog.StorageCredentialInfo`. * Added `dashboard` field for `databricks.sdk.service.dashboards.CreateDashboardRequest`. * Added `schedule` field for `databricks.sdk.service.dashboards.CreateScheduleRequest`. * Added `subscription` field for `databricks.sdk.service.dashboards.CreateSubscriptionRequest`. * Added `warehouse_id` field for `databricks.sdk.service.dashboards.Schedule`. * Added `dashboard` field for `databricks.sdk.service.dashboards.UpdateDashboardRequest`. * Added `schedule` field for `databricks.sdk.service.dashboards.UpdateScheduleRequest`. * Added `page_token` field for `databricks.sdk.service.oauth2.ListServicePrincipalSecretsRequest`. * Added `next_page_token` field for `databricks.sdk.service.oauth2.ListServicePrincipalSecretsResponse`. * Added `connection_name` field for `databricks.sdk.service.pipelines.IngestionGatewayPipelineDefinition`. * Added `is_no_public_ip_enabled` field for `databricks.sdk.service.provisioning.CreateWorkspaceRequest`. * Added `external_customer_info` and `is_no_public_ip_enabled` fields for `databricks.sdk.service.provisioning.Workspace`. * Added `last_used_day` field for `databricks.sdk.service.settings.TokenInfo`. * Changed `create()` method for [w.apps](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/apps.html) workspace-level service with new required argument order. * Changed `execute_message_query()` method for [w.genie](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/genie.html) workspace-level service . New request type is `databricks.sdk.service.dashboards.GenieExecuteMessageQueryRequest` dataclass. * Changed `execute_message_query()` method for [w.genie](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/genie.html) workspace-level service to type `execute_message_query()` method for [w.genie](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/genie.html) workspace-level service. * Changed `create()`, `create_schedule()`, `create_subscription()` and `update_schedule()` methods for [w.lakeview](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/lakeview.html) workspace-level service with new required argument order. * Removed [w.clean_rooms](https://databricks-sdk-py.readthedocs.io/en/latest/workspace/clean_rooms.html) workspace-level service. * Removed `prev_page_token` field for `databricks.sdk.service.jobs.Run`. * Removed `deployment_id`, `mode` and `source_code_path` fields for `databricks.sdk.service.apps.CreateAppDeploymentRequest`. * Removed `description`, `name` and `resources` fields for `databricks.sdk.service.apps.CreateAppRequest`. * Removed `description` and `resources` fields for `databricks.sdk.service.apps.UpdateAppRequest`. * Removed `name` and `spec` fields for `databricks.sdk.service.catalog.CreateOnlineTableRequest`. * Removed `display_name`, `parent_path`, `serialized_dashboard` and `warehouse_id` fields for `databricks.sdk.service.dashboards.CreateDashboardRequest`. * Removed `cron_schedule`, `display_name` and `pause_status` fields for `databricks.sdk.service.dashboards.CreateScheduleRequest`. * Removed `subscriber` field for `databricks.sdk.service.dashboards.CreateSubscriptionRequest`. * Removed `display_name`, `etag`, `serialized_dashboard` and `warehouse_id` fields for `databricks.sdk.service.dashboards.UpdateDashboardRequest`. * Removed `cron_schedule`, `display_name`, `etag` and `pause_status` fields for `databricks.sdk.service.dashboards.UpdateScheduleRequest`. OpenAPI SHA: 5285ce76f81314f342c1702d5c2ad4ef42488781, Date: 2024-11-04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Correctly generate classes with nested body fields.
Backwards incompatible changes
The next time code is generated, the following backward incompatible changes will happen:
apps.CreateAppDeploymentRequest,apps.CreateAppRequest,apps.UpdateAppRequest,catalog.CreateOnlineTableRequest,dashboards.CreateDashboardRequest,dashboards.CreateScheduleRequest,dashboards.CreateSubscriptionRequest,dashboards.UpdateDashboardRequestanddashboards.UpdateScheduleRequestAppsAPI.create,AppsAPI.create_and_wait,AppsAPI.deploy,AppsAPI.deploy_and_wait,AppsAPI.update,OnlineTablesAPI.create,OnlineTablesAPI.create_and_wait,LakeviewAPI.create,LakeviewAPI.create_schedule,LakeviewAPI.create_subscription,LakeviewAPI.updateandLakeviewAPI.update_schedule. Each of those methods now take an object instead of a list of parameters.Tests
Preview
66ce450
make testrun locallymake fmtapplied