Skip to content

Ensure that refresh tokens are returned when using the external-browser credentials strategy #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025
Merged

Ensure that refresh tokens are returned when using the external-browser credentials strategy #931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50e12b0
fix
mgyucht Mar 20, 2025
6f2a3b1
one other cleanup
mgyucht Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEXT_CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

### Bug Fixes

* Ensure that refresh tokens are returned when using the `external-browser` credentials strategy.

### Documentation

### Internal Changes
Expand Down
8 changes: 5 additions & 3 deletions databricks/sdk/oauth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,11 @@ def __init__(
):

if not scopes:
scopes = ["all-apis"]
# all-apis ensures that the returned OAuth token can be used with all APIs, aside
# from direct-to-dataplane APIs.
# offline_access ensures that the response from the Authorization server includes
# a refresh token.
scopes = ["all-apis", "offline_access"]

self.redirect_url = redirect_url
self._client_id = client_id
Expand All @@ -654,8 +658,6 @@ def noop_credentials(_: any):
return lambda: {}

config = Config(host=host, credentials_strategy=noop_credentials)
if not scopes:
scopes = ["all-apis"]
oidc = config.oidc_endpoints
if not oidc:
raise ValueError(f"{host} does not support OAuth")
Expand Down
Loading