Skip to content

Arrange services in a per package sdk approach #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Apr 10, 2025
Merged

Arrange services in a per package sdk approach #941

merged 21 commits into from
Apr 10, 2025

Conversation

@parthban-db
Copy link
Contributor

@parthban-db parthban-db commented Mar 28, 2025 •
edited
Loading

What changes are proposed in this pull request?

This PR moves all the service packages into separate packages and isolates them from each other. It also removes the workspace and account clients, which are replaced by the per-service clients.
Note: waiters and data plane services are removed and need to be enabled again.

How is this tested?

  • Modified existing tests to use service clients instead of workspace and account clients.
  • Few tests are commented out, like tests involving waiters.
  • WorkspaceClient, AccountClient Test creation tests are deleted.

NO_CHANGELOG=true

@parthban-db parthban-db force-pushed the parthban-db/generate-expand-openapi branch from 17d486b to 4e23809 Compare April 9, 2025 19:30
hectorcast-db
hectorcast-db reviewed Apr 10, 2025
View reviewed changes
hectorcast-db
hectorcast-db approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@hectorcast-db hectorcast-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with small question. Can be done afterwards.

@github-actions
Copy link

github-actions bot commented Apr 10, 2025

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-py

Inputs:

  • PR number: 941
  • Commit SHA: 2910d4dae0d733e3181de22a7bf1fc8711f1221d

Checks will be approved automatically on success.

@parthban-db parthban-db added this pull request to the merge queue Apr 10, 2025
Merged via the queue into dev/sdk-mod with commit 5709a9c Apr 10, 2025
17 checks passed
@parthban-db parthban-db deleted the parthban-db/generate-expand-openapi branch April 10, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hectorcast-db hectorcast-db hectorcast-db approved these changes

@renaudhartert-db renaudhartert-db renaudhartert-db approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@parthban-db @hectorcast-db @renaudhartert-db